Re: [PATCH v2 1/4] Add gdbpy_borrowed_ref

[Tom Tromey <tom@tromey.com>]

>> This adds new gdbpy_opt_borrowed_ref and gdbpy_borrowed_ref classes.
>> These class is primarily for code "documentation" purposes -- it makes

Andrew> type: These CLASSES ARE primarily ....

Fixed.

Andrew> Could/should this be marked as 'const'?

Yeah, plus the other ones you pointed out.

>> +  /* Allow a (checked) conversion to any subclass of PyObject.  */
>> +  template<typename T,
>> +	   typename = std::is_convertible<T *, PyObject *>>
>> +  operator T * ()
>> +  {
>> +    gdb_assert (PyObject_TypeCheck (m_obj, T::corresponding_object_type));
>> +    return static_cast<T *> (m_obj);
>> +  }

Andrew> OK, please excuse my ignorance here, I might be completely wrong, but I
Andrew> believe the line 'typename = std::is_convertible<T *, PyObject *>' is
Andrew> here for the purpose of SFINAE.  I believe this was copied from
Andrew> gdb_ref_ptr.h, but I think this line might be wrong, both there and
Andrew> here.

Yep, oops.

I fixed this here & sent a separate patch for gdb_ref_ptr.h.

Tom