Re: [PATCH v2 3/4] Add wrappers for Python implementation functions and methods

[Tom Tromey <tom@tromey.com>]

>> +noargs_method (std::string_view name, std::string_view doc)

Andrew> Using std::string_view seems a little suspect here.

Yeah.  I think some earlier attempt at this required string_view, but
I've changed it to 'const char *' and it's fine.

>> +/* A function that wraps a "repr" or "str" method.  */
>> +template<typename C, auto M>
>> +PyObject *
>> +wrap_repr (PyObject *arg)

Andrew> Maybe something like 'wrap_tp_callback' might be better?  I just know
Andrew> every time I see 'wrap_repr' for something that isn't 'repr' I'm going
Andrew> to assume copy & paste error, and then have to go and remind myself that
Andrew> 'wrap_repr' has wider uses.  Now's a great time to find a better name
Andrew> before this starts getting used more widely..

I changed it to wrap_tp_callback.

Tom