Re: [PATCH v2 4/4] Convert py-tui.c to the "python safety" approach

[Tom Tromey <tom@tromey.com>]

>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:

>> * gdb.register_tui_window is converted and simply returns 'void'.

Andrew> typo: gdb.register_tui_window should be gdbpy_register_tui_window I think.

I used the Python name rather than the C++ name.
I'll change it though.

>> /* Return true if this object is valid.  */
>> -  bool is_valid () const;
>> +  bool is_valid ();

Andrew> Dropping 'const' here is unfortunate, and I think is a consequence of
Andrew> either noargs_method or maybe wrapped_method requiring non-const.

I will look but perhaps add the overloads on an as-needed basis.

Andrew> Can we add a 'const' aware overload of noargs_method, or wrapped_method,
Andrew> or whatever, and allow is_valid to retain the const qualifier?

Yep, I fixed this.

Andrew> If this works, then there might be other places in the wrapper functions
Andrew> (patch #3) where we could/should add const overloads.

>> +  /* FIXME: safety */

Andrew> Please can you expand this comment.  I know this is something you're
Andrew> actively working on, and the plan is that this comment probably
Andrew> shouldn't exist in the code for too long.  But it might, so we should
Andrew> assume that it will, and write this accordingly.

I did this.

Andrew> I'll be honest, even with the commit message hint, I don't really
Andrew> understand what it is that needs fixing here, I guess it's that you'd
Andrew> like python_string_to_host_string to throw rather than return NULL?  But
Andrew> the issue is that this function is used in non-safety code, so cannot
Andrew> (currently) be changed?

Yes, that's correct.

Tom