From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ggsyOshyD2p+aw0AWB0awg (envelope-from ) for ; Thu, 21 May 2026 17:02:00 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=E5kMgt+5; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D182A1E091; Thu, 21 May 2026 17:02:00 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C34BA1E024 for ; Thu, 21 May 2026 17:01:59 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C1CE648F8E1A for ; Thu, 21 May 2026 21:01:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C1CE648F8E1A Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=E5kMgt+5 Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by sourceware.org (Postfix) with ESMTPS id 93A1249002D1 for ; Thu, 21 May 2026 21:01:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 93A1249002D1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 93A1249002D1 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=44.202.169.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779397287; cv=none; b=Ff5bV9xWZZa62Six4vpMCaIlD7v57zu16aNZy2Nakxm/CjJKBCyJFsTarkHfPGPLFY3jaocfTyJMhHvO+hg4fo7m9SewvSihNqUD9GTx91erpQCXTvmoxxdt1jJVwjdU8CEoVXnHDDRww7Q/XHY39oDjOv/cJSKpB/Dl5LNS3/M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779397287; c=relaxed/simple; bh=xeqqa+jA6N7ir/EykqaJWUQ+pNT8ALdDpZl5icfP/bs=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=IhG7X2PjFDPZ95QcxtCcw+7iengk1s4rboDBQwuxh/rcVs4/OWU8xqqrqElhyV5o9fdw98bDtOC2F6Cot9XHDXAVCJzNXtJVI6vuSNg9+2opBZOB4fsxt+4rJ1YNrJJPQ/UWya+oJo83T0k8nW/+pclz7B8lPI1gP72wtVGUU+0= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=E5kMgt+5 reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 93A1249002D1 Received: from eig-obgw-6003b.ext.cloudfilter.net ([10.0.30.175]) by cmsmtp with ESMTPS id Q6kdwv4Q2KSRRQAWEwzzwA; Thu, 21 May 2026 21:01:27 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id QAWEwd0kf3HCDQAWEwtgAP; Thu, 21 May 2026 21:01:26 +0000 X-Authority-Analysis: v=2.4 cv=TOdFS0la c=1 sm=1 tr=0 ts=6a0f72a6 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=NGcC8JguVDcA:10 a=ItBw4LHWJt0A:10 a=BKDlrIXCSSW5O673fcAA:9 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=9tVLGp7cJisVhL5FdnYJ2O5ETGReYSAY6zcpiZX0sf8=; b=E5kMgt+59xuDw03ZnjOkJuLy1t k4tjDmfTr/QhYZIhKrljssC6XgacDbXDui1e+Gg82CQT4SIS5mgZg9xOMxzYoQDUV0FwZlVEvAbZx n96rMe9I6IOuIBwQVer+iAMxF; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:49046 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.2) (envelope-from ) id 1wQAWD-00000000Sin-3BtK; Thu, 21 May 2026 15:01:25 -0600 From: Tom Tromey To: Andrew Burgess Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH v2 1/4] Add gdbpy_borrowed_ref In-Reply-To: <87cxyuclhd.fsf@redhat.com> (Andrew Burgess's message of "Sun, 17 May 2026 12:40:46 +0100") References: <20260515-python-safety-initial-v2-0-6129cadf258a@tromey.com> <20260515-python-safety-initial-v2-1-6129cadf258a@tromey.com> <87cxyuclhd.fsf@redhat.com> X-Attribution: Tom Date: Thu, 21 May 2026 15:01:24 -0600 Message-ID: <87jyswjx3v.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wQAWD-00000000Sin-3BtK X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (prentzel) [75.166.225.82]:49046 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfFMN8QzSJh6b31ZlYl+YoLY5PjtkWpmhYlsQuo1X9n7UrfGbu/KP+KsWvDFqBI9AFqt0soyrpCdZ/nGPRvrJrFWt71/+N4dn8/yYkAhVkL2uFNfIVr0q lG7Mh8Wn52eWqyEzM/99n5sS5ox0UHdkZj+27rVYyy2N+u0azcP4S1gZ9QVVUhoarkR5oS4Je0t1yj1NuzGGgT1w8KQaE2C39XU= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >> This adds new gdbpy_opt_borrowed_ref and gdbpy_borrowed_ref classes. >> These class is primarily for code "documentation" purposes -- it makes Andrew> type: These CLASSES ARE primarily .... Fixed. Andrew> Could/should this be marked as 'const'? Yeah, plus the other ones you pointed out. >> + /* Allow a (checked) conversion to any subclass of PyObject. */ >> + template> + typename = std::is_convertible> >> + operator T * () >> + { >> + gdb_assert (PyObject_TypeCheck (m_obj, T::corresponding_object_type)); >> + return static_cast (m_obj); >> + } Andrew> OK, please excuse my ignorance here, I might be completely wrong, but I Andrew> believe the line 'typename = std::is_convertible' is Andrew> here for the purpose of SFINAE. I believe this was copied from Andrew> gdb_ref_ptr.h, but I think this line might be wrong, both there and Andrew> here. Yep, oops. I fixed this here & sent a separate patch for gdb_ref_ptr.h. Tom