[RFA] Fix a typo

[RFA] Fix a typo

[Siva Chandra]

[-- Attachment #1: Type: text/plain, Size: 218 bytes --]

Hello,

The attached patch fixes, what looks to me like, a definite typo.

2012-06-08  Siva Chandra Reddy  <sivachandra@google.com>

        * valarith.c (binop_types_user_defined_p): Fix a typo.

Thanks,
Siva Chandra

[-- Attachment #2: typo_patch.txt --]
[-- Type: text/plain, Size: 600 bytes --]

Index: valarith.c
===================================================================
RCS file: /cvs/src/src/gdb/valarith.c,v
retrieving revision 1.103
diff -u -p -r1.103 valarith.c
--- valarith.c	18 May 2012 21:02:50 -0000	1.103
+++ valarith.c	8 Jun 2012 19:03:23 -0000
@@ -279,7 +279,7 @@ binop_types_user_defined_p (enum exp_opc
   if (TYPE_CODE (type1) == TYPE_CODE_REF)
     type1 = check_typedef (TYPE_TARGET_TYPE (type1));
 
-  type2 = check_typedef (type1);
+  type2 = check_typedef (type2);
   if (TYPE_CODE (type2) == TYPE_CODE_REF)
     type2 = check_typedef (TYPE_TARGET_TYPE (type2));
 

Re: [RFA] Fix a typo

[Tom Tromey]

>>>>> "Siva" == Siva Chandra <sivachandra@google.com> writes:

Siva> The attached patch fixes, what looks to me like, a definite typo.
Siva> 2012-06-08  Siva Chandra Reddy  <sivachandra@google.com>
Siva>         * valarith.c (binop_types_user_defined_p): Fix a typo.

This is ok.  Nice catch.

If it is possible to write a test case for this, that would be nice to
have.  But maybe it isn't possible without other fixes ... ?

Tom

Re: [RFA] Fix a typo

[Siva Chandra]

On Sat, Jun 9, 2012 at 2:01 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Siva" == Siva Chandra <sivachandra@google.com> writes:
>
> Siva> The attached patch fixes, what looks to me like, a definite typo.
> Siva> 2012-06-08  Siva Chandra Reddy  <sivachandra@google.com>
> Siva>         * valarith.c (binop_types_user_defined_p): Fix a typo.
>
> This is ok.  Nice catch.
>
> If it is possible to write a test case for this, that would be nice to
> have.  But maybe it isn't possible without other fixes ... ?

Yes, I will add the tests with the next change. Committed the above patch now.

Thanks,
Siva Chandra