From: Siva Chandra <sivachandra@google.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Fix a typo
Date: Sat, 09 Jun 2012 07:38:00 -0000 [thread overview]
Message-ID: <CAGyQ6gzbVr8N1m=CeKtdGDwN5y_+vttYqWMAikkGOQLwSQm--Q@mail.gmail.com> (raw)
In-Reply-To: <87ipf1czqf.fsf@fleche.redhat.com>
On Sat, Jun 9, 2012 at 2:01 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Siva" == Siva Chandra <sivachandra@google.com> writes:
>
> Siva> The attached patch fixes, what looks to me like, a definite typo.
> Siva> 2012-06-08 Siva Chandra Reddy <sivachandra@google.com>
> Siva> * valarith.c (binop_types_user_defined_p): Fix a typo.
>
> This is ok. Nice catch.
>
> If it is possible to write a test case for this, that would be nice to
> have. But maybe it isn't possible without other fixes ... ?
Yes, I will add the tests with the next change. Committed the above patch now.
Thanks,
Siva Chandra
prev parent reply other threads:[~2012-06-09 7:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 19:43 Siva Chandra
2012-06-08 20:31 ` Tom Tromey
2012-06-09 7:38 ` Siva Chandra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGyQ6gzbVr8N1m=CeKtdGDwN5y_+vttYqWMAikkGOQLwSQm--Q@mail.gmail.com' \
--to=sivachandra@google.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox