From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27177 invoked by alias); 8 Jun 2012 20:31:40 -0000 Received: (qmail 27169 invoked by uid 22791); 8 Jun 2012 20:31:39 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 08 Jun 2012 20:31:22 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q58KVLxF020559 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 8 Jun 2012 16:31:21 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q58KVKMX022509 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 8 Jun 2012 16:31:21 -0400 From: Tom Tromey To: Siva Chandra Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Fix a typo References: Date: Fri, 08 Jun 2012 20:31:00 -0000 In-Reply-To: (Siva Chandra's message of "Sat, 9 Jun 2012 01:12:47 +0530") Message-ID: <87ipf1czqf.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.97 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00246.txt.bz2 >>>>> "Siva" == Siva Chandra writes: Siva> The attached patch fixes, what looks to me like, a definite typo. Siva> 2012-06-08 Siva Chandra Reddy Siva> * valarith.c (binop_types_user_defined_p): Fix a typo. This is ok. Nice catch. If it is possible to write a test case for this, that would be nice to have. But maybe it isn't possible without other fixes ... ? Tom