Re: [PATCH 0/6] Add gdbarch-checking script

[Sergio Durigan Junior <sergiodj@sergiodj.net>]

On Thursday, December 05 2024, Keith Seitz wrote:

> Hi, Tom,
>
> [It's me again!]

Hey you two :-),

> On 11/4/24 1:14 PM, Tom Tromey wrote:
[...]
>> A few other gdbarch settings are used by gdb but not set by any
>> existing arch.  I haven't removed these since they maybe needed more
>> discussion:
>>      stap_gdb_register_suffix
>>      stap_integer_suffixes
>>      stap_register_suffixes
>
> I briefly discussed these with fche, and it certainly appears
> that the compiler *could* output these suffixes. However, it seems
> that either no one has generated a probe that does this (and/or
> tried to debug it), or no one has reported any problems.
>
> I agree these need further discussion, but while I understand
> the desire to simplify, I still lean toward keeping these around.

I agree.  I believe it makes sense to leave them around because it's a
logical (IMHO) thing to expect that registers might have prefixes (which
are indeed being used) *and* suffixes.  If you remove them, you'll have
to touch stap-probe.c as well FWIW.

Thanks,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
https://sergiodj.net/