Re: [PATCH 5/6] Remove the print_vector_info gdbarch hook

[Keith Seitz <keiths@redhat.com>]

Hi,

One really tiny, tiny request:

On 11/4/24 1:14 PM, Tom Tromey wrote:

> diff --git a/gdb/infcmd.c b/gdb/infcmd.c
> index 74873b9f7c80fa2ec299f528cde748161882c175..db9d6e66b57b700b7dc9b7bd6176fdc0ac888ef3 100644
> --- a/gdb/infcmd.c
> +++ b/gdb/infcmd.c
> @@ -2404,25 +2404,18 @@ print_vector_info (struct ui_file *file,
>   		   const frame_info_ptr &frame, const char *args)
>   {
>     struct gdbarch *gdbarch = get_frame_arch (frame);
> +  int printed_something = 0;

Since you're here, would you mind changing `printed_something' to a bool?

[I warned you it was teeny tiny!]

Keith

>   
> -  if (gdbarch_print_vector_info_p (gdbarch))
> -    gdbarch_print_vector_info (gdbarch, file, frame, args);
> -  else
> +  for (int regnum = 0; regnum < gdbarch_num_cooked_regs (gdbarch); regnum++)
>       {
> -      int regnum;
> -      int printed_something = 0;
> -
> -      for (regnum = 0; regnum < gdbarch_num_cooked_regs (gdbarch); regnum++)
> +      if (gdbarch_register_reggroup_p (gdbarch, regnum, vector_reggroup))
>   	{
> -	  if (gdbarch_register_reggroup_p (gdbarch, regnum, vector_reggroup))
> -	    {
> -	      printed_something = 1;
> -	      gdbarch_print_registers_info (gdbarch, file, frame, regnum, 1);
> -	    }
> +	  printed_something = 1;
> +	  gdbarch_print_registers_info (gdbarch, file, frame, regnum, 1);
>   	}
> -      if (!printed_something)
> -	gdb_printf (file, "No vector information\n");
>       }
> +  if (!printed_something)
> +    gdb_printf (file, "No vector information\n");
>   }
>   
>   static void
>