Re: [PATCH 1/6] Add check-gdbarch.py

[Keith Seitz <keiths@redhat.com>]

Hi,

On 11/4/24 1:14 PM, Tom Tromey wrote:
> This adds a new check-gdbarch.py script.  This script checks the
> sources to see which gdbarch methods are set but never called, and
> which ones are called but never set.

While I was playing with this, I (naively?) tried to run the script
from my play branch in my virgin master branch. Much to my surprise,
it output exactly the same output as when it was run in my play
branch (which contains this entire series).

Do we care? If not, please feel free to ignore this.

It's a pretty easy thing to change:

diff --git a/gdb/check-gdbarch.py b/gdb/check-gdbarch.py
index 6f2983c7984..da27c481017 100755
--- a/gdb/check-gdbarch.py
+++ b/gdb/check-gdbarch.py
@@ -21,9 +21,14 @@

  import fileinput
  import glob
+import os
  import re
  import sys

+# Insert CWD in case this script is run from some other gdb src
+# directory.
+sys.path.insert(0, os.getcwd())
+
  # gdbarch_components is imported only for its side-effect of filling
  # `gdbarch_types.components`.
  import gdbarch_components  # noqa: F401 # type: ignore

Keith