From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4Nk9OgIuUmebUwUAWB0awg (envelope-from ) for ; Thu, 05 Dec 2024 17:49:38 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=BWXf2gDJ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id EB6031E197; Thu, 5 Dec 2024 17:49:38 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A34E71E05C for ; Thu, 5 Dec 2024 17:49:38 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4CAD03858CDA for ; Thu, 5 Dec 2024 22:49:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4CAD03858CDA Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=BWXf2gDJ Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 024F03858D21 for ; Thu, 5 Dec 2024 22:49:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 024F03858D21 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 024F03858D21 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1733438949; cv=none; b=KB9gDEALuppDW9lNRtnTzSPk3+C5LxZIVuAeAo+6i3oGwzu9ChlfHliDRi3Fn5dkEGVTKPZb3ehysGzqeqKKfsaQbwit7gQCdwOjgChUUghNHUqHOHUWlxd2ScOgrpecTsmMd4lSnIR0UZ8QybwBaYPtmDRlrd2u98F68JSc4LI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1733438949; c=relaxed/simple; bh=oB0UEcR5Eq3SMfBuc42gbxwiSii3iLGbkVRK2sbHgCg=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=CjwQuFraTGk6jN0jeqG5Hhamd8BLOqvaLP0ohv3tsW4LwWVaR/u1T8fC0VM7pqCOaDb7u1h5raNTtd4jmV7/DRrL+8cKnw9xd62pIgSuTkFzc6MYDbruGIuVvOmwl/EzMK584MAKhASzOhmCulE5zLdUBSjMDmdtzv6tKb4cctg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 024F03858D21 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733438948; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t9u6D3IfPuMo0Hlms1k6dpnyqwsCYkQ3YXOEiBLyTFs=; b=BWXf2gDJ4Fqjpi94mfhhXSQkhj4VoU/abVKPxHR56S96vUb+UwBve7/2Xt9uxJr4nA8YEa lzUhWjo4lw/ASQZAcA67+PU469mi8LEJhVyIXjV9zeNqO4ksGnNl9rDEiLk42QGquaburw NfuFnzTCA48Q3zg57DjG27Tt3gvWWiw= Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-347-7Wb2RTm3NpCUfYRx8RLCMw-1; Thu, 05 Dec 2024 17:49:05 -0500 X-MC-Unique: 7Wb2RTm3NpCUfYRx8RLCMw-1 X-Mimecast-MFC-AGG-ID: 7Wb2RTm3NpCUfYRx8RLCMw Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-2ee4f3785f6so1389574a91.2 for ; Thu, 05 Dec 2024 14:49:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733438944; x=1734043744; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=t9u6D3IfPuMo0Hlms1k6dpnyqwsCYkQ3YXOEiBLyTFs=; b=iVGnRqFfVHfP5epFtRGiN8/y99rUp0j33VwgQiJZmG5mSj8p5Dl5YtYiK9Hbo2LQM0 eqhssFRRs6nlPDW63aFvtzNXKHaV2RqRfnM+MBY+aAmuubosO1BvatLQny7USQmze2IX AvYZLbIxETGl2ROOjCa6HGQzIAOlq5O+/yoeNICWAS0gpZul5PebPJJ+y6BldITcLXdZ Kbh5plHR29j31ZjDnslPe0EsZ9Aq9hq9zoICDnFfrCbctsYiimh18EO+1oE4i8YZdOFR MkVO17DHpbf/pCjLRY+vXg2QebEOdaw0TMi3UccyxBPmvENda4KnPCfMy202BBizjTvd K93g== X-Forwarded-Encrypted: i=1; AJvYcCXyZJNpcG32MwWSp7m5bJyy6/4uxOWhvtuJdVieo7SGw2zz0errGD41dOR8lsG2gYrc5lxkHoap9OvfUA==@sourceware.org X-Gm-Message-State: AOJu0YyvuQPceKUb0vv9j/o1bCsDoC9CY5Cqujwdd7BSxZ1JIe9MlUsO jvm4irbwicUYjDRoZiSRzzIFUH5DY1XGvg/deOTdoT+7jwJq7QRAESbFBMwjVCKsRMeu1f2Jyjm gBiuaPugEGJ/InMm2ywAnC/9T9O4ZvnBIl0rffYH6OQ+yvhWctLsRBdhe4bEt71aGfsV1Ew== X-Gm-Gg: ASbGnctHY5d68SRSr6HZCaqUr/mGII7oach6I5rCBZiX0uGqxu3LPgr8kcjOCq+cSkE nNgfIrM+jenH1iXrEKt2n2LWPgG1/CI1eqDNmbG2U4vkmqXsL/4tBGhGEzom/doBG6rQDjbQWx2 4H275z2ypZnX76+afu203bSUDrRtW5lOZBDBk8IktpXh2RlQfEark6P9mQLjVIIypv6P/apfYiY uRrM2nICnUEkNpmRjfCUTqXTterGhJuWHl2XsYhJRseLDu2IM53ZYw= X-Received: by 2002:a17:90b:1a8c:b0:2ee:693e:ed7c with SMTP id 98e67ed59e1d1-2ef6ab2552cmr1373833a91.33.1733438943982; Thu, 05 Dec 2024 14:49:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IGbTNIuXrqaJ2raVkUfVzonorf0rB7+HNZ8+TUKH/PiOqd+5w7DJM5qesfT82SY6YGQXusBpw== X-Received: by 2002:a17:90b:1a8c:b0:2ee:693e:ed7c with SMTP id 98e67ed59e1d1-2ef6ab2552cmr1373818a91.33.1733438943709; Thu, 05 Dec 2024 14:49:03 -0800 (PST) Received: from [150.1.200.127] ([172.56.107.48]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2ef27078b03sm4141543a91.38.2024.12.05.14.49.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Dec 2024 14:49:03 -0800 (PST) Message-ID: <53f05ae9-d14b-406f-bbbc-3fee92e321f7@redhat.com> Date: Thu, 5 Dec 2024 14:49:02 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/6] Remove the print_vector_info gdbarch hook To: Tom Tromey , gdb-patches@sourceware.org References: <20241104-check-unused-gdbarch-v1-0-7082f2121077@tromey.com> <20241104-check-unused-gdbarch-v1-5-7082f2121077@tromey.com> From: Keith Seitz In-Reply-To: <20241104-check-unused-gdbarch-v1-5-7082f2121077@tromey.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: mATzE85ATxm2amdRwLKfmIO1DelplNtjfsvNH7YFhuA_1733438944 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi, One really tiny, tiny request: On 11/4/24 1:14 PM, Tom Tromey wrote: > diff --git a/gdb/infcmd.c b/gdb/infcmd.c > index 74873b9f7c80fa2ec299f528cde748161882c175..db9d6e66b57b700b7dc9b7bd6176fdc0ac888ef3 100644 > --- a/gdb/infcmd.c > +++ b/gdb/infcmd.c > @@ -2404,25 +2404,18 @@ print_vector_info (struct ui_file *file, > const frame_info_ptr &frame, const char *args) > { > struct gdbarch *gdbarch = get_frame_arch (frame); > + int printed_something = 0; Since you're here, would you mind changing `printed_something' to a bool? [I warned you it was teeny tiny!] Keith > > - if (gdbarch_print_vector_info_p (gdbarch)) > - gdbarch_print_vector_info (gdbarch, file, frame, args); > - else > + for (int regnum = 0; regnum < gdbarch_num_cooked_regs (gdbarch); regnum++) > { > - int regnum; > - int printed_something = 0; > - > - for (regnum = 0; regnum < gdbarch_num_cooked_regs (gdbarch); regnum++) > + if (gdbarch_register_reggroup_p (gdbarch, regnum, vector_reggroup)) > { > - if (gdbarch_register_reggroup_p (gdbarch, regnum, vector_reggroup)) > - { > - printed_something = 1; > - gdbarch_print_registers_info (gdbarch, file, frame, regnum, 1); > - } > + printed_something = 1; > + gdbarch_print_registers_info (gdbarch, file, frame, regnum, 1); > } > - if (!printed_something) > - gdb_printf (file, "No vector information\n"); > } > + if (!printed_something) > + gdb_printf (file, "No vector information\n"); > } > > static void >