From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id OFo8O5JoUmd3fgUAWB0awg (envelope-from ) for ; Thu, 05 Dec 2024 21:59:30 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=sergiodj.net header.i=@sergiodj.net header.a=rsa-sha256 header.s=20160602 header.b=r8Vzu5h6; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id EFB651E197; Thu, 5 Dec 2024 21:59:30 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 929F21E05C for ; Thu, 5 Dec 2024 21:59:30 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 285683858C52 for ; Fri, 6 Dec 2024 02:59:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 285683858C52 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=sergiodj.net header.i=@sergiodj.net header.a=rsa-sha256 header.s=20160602 header.b=r8Vzu5h6 Received: from mail.sergiodj.net (mail.sergiodj.net [195.201.110.160]) by sourceware.org (Postfix) with ESMTPS id 410CE3858D28 for ; Fri, 6 Dec 2024 02:58:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 410CE3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=sergiodj.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=sergiodj.net ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 410CE3858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.201.110.160 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1733453938; cv=none; b=B/Fp93HFldzCR1m4/LEDzaR4qVdtv/zNUXsbjMOwl8ECsKSioh7o8LUtpxDWLJI306SJ4b7w8ZJdyAE7SwLhVRqTP682S9CgucrlsWZh0tmiMgEWxnyDEliBGoK4yIiWcsxoHxZPSGzh660IKj2Dx3kGZatM7JkihLLVgl/J/eE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1733453938; c=relaxed/simple; bh=h84orgcs1Maywld7I2vdy7GRoRGD5Itw3V1WuFyj5js=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=BLf+9QIC2hvJmOBgAjciBdyPfxzDJXLPJ+oNVM0uwCvHPm69bXVdF2MuBnAH1oTej1APRu+9WxLb3DlJjmt7IBrtNmOFpYfX0QyvNCELwmq5MFsMfDCEN+36J1+zJD619cThpNoqf9sBOrfrVSG5xOpnkSP29FyXMlBlioRdDzo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 410CE3858D28 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=sergiodj.net; s=20160602; t=1733453936; bh=h84orgcs1Maywld7I2vdy7GRoRGD5Itw3V1WuFyj5js=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=r8Vzu5h663Wj6/B3/Z8NcjaPH1TXSAJMWR6ZDYdFHvMYH0/Y3p/nD6AeUoveWN59N k3YRznO6YmIv/3CXlKn8J5z3YFOefVnCsCxoCuxm+opDdk5LK9YpAJp96KXb1XqN14 V303HuvICVanrLUcbDIt4c1d7pubaa7toeVXL+t4= From: Sergio Durigan Junior To: Keith Seitz Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 0/6] Add gdbarch-checking script In-Reply-To: <41518c65-4f78-481f-b381-e120d9546d29@redhat.com> (Keith Seitz's message of "Thu, 5 Dec 2024 14:50:57 -0800") References: <20241104-check-unused-gdbarch-v1-0-7082f2121077@tromey.com> <41518c65-4f78-481f-b381-e120d9546d29@redhat.com> X-URL: http://blog.sergiodj.net Date: Thu, 05 Dec 2024 21:58:54 -0500 Message-ID: <87h67h5xg1.fsf@sergiodj.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Thursday, December 05 2024, Keith Seitz wrote: > Hi, Tom, > > [It's me again!] Hey you two :-), > On 11/4/24 1:14 PM, Tom Tromey wrote: [...] >> A few other gdbarch settings are used by gdb but not set by any >> existing arch. I haven't removed these since they maybe needed more >> discussion: >> stap_gdb_register_suffix >> stap_integer_suffixes >> stap_register_suffixes > > I briefly discussed these with fche, and it certainly appears > that the compiler *could* output these suffixes. However, it seems > that either no one has generated a probe that does this (and/or > tried to debug it), or no one has reported any problems. > > I agree these need further discussion, but while I understand > the desire to simplify, I still lean toward keeping these around. I agree. I believe it makes sense to leave them around because it's a logical (IMHO) thing to expect that registers might have prefixes (which are indeed being used) *and* suffixes. If you remove them, you'll have to touch stap-probe.c as well FWIW. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible https://sergiodj.net/