From: Tom Tromey <tromey@redhat.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org, eliz@gnu.org
Subject: Re: [RFA, doc RFA] Add "set debug symfile on".
Date: Wed, 25 Sep 2013 19:57:00 -0000 [thread overview]
Message-ID: <87fvssisi8.fsf@fleche.redhat.com> (raw)
In-Reply-To: <yjt261tpbvdj.fsf@ruffy.mtv.corp.google.com> (Doug Evans's message of "Tue, 24 Sep 2013 17:25:12 -0700")
>>>>> "Doug" == Doug Evans <dje@google.com> writes:
Doug> This patch adds a new debugging option: set debug symfile on
Doug> For now it logs all calls through the symfile functions.
Doug> Regression tested on amd64-linux.
Doug> Ok to check in?
It seems ok to me.
This patch combines a few different things into one. For example,
reordering the arguments to map_matching_symbols has no relation to the
rest of the patch. We normally make other contributors split such
patches. I think it is best if maintainers do this as well.
Tom
next prev parent reply other threads:[~2013-09-25 19:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-25 0:25 Doug Evans
2013-09-25 0:31 ` Doug Evans
2013-09-25 5:57 ` Eli Zaretskii
2013-09-25 19:57 ` Tom Tromey [this message]
2013-09-25 21:03 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvssisi8.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=dje@google.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox