From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-105760-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 32514 invoked by alias); 25 Sep 2013 19:57:41 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 32503 invoked by uid 89); 25 Sep 2013 19:57:41 -0000
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 25 Sep 2013 19:57:41 +0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r8PJvanE028213	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 25 Sep 2013 15:57:36 -0400
Received: from barimba (ovpn-113-63.phx2.redhat.com [10.3.113.63])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r8PJvZ6E000662	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Wed, 25 Sep 2013 15:57:35 -0400
From: Tom Tromey <tromey@redhat.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org, eliz@gnu.org
Subject: Re: [RFA, doc RFA] Add "set debug symfile on".
References: <yjt261tpbvdj.fsf@ruffy.mtv.corp.google.com>
Date: Wed, 25 Sep 2013 19:57:00 -0000
In-Reply-To: <yjt261tpbvdj.fsf@ruffy.mtv.corp.google.com> (Doug Evans's	message of "Tue, 24 Sep 2013 17:25:12 -0700")
Message-ID: <87fvssisi8.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2013-09/txt/msg00905.txt.bz2

>>>>> "Doug" == Doug Evans <dje@google.com> writes:

Doug> This patch adds a new debugging option: set debug symfile on

Doug> For now it logs all calls through the symfile functions.

Doug> Regression tested on amd64-linux.

Doug> Ok to check in?

It seems ok to me.

This patch combines a few different things into one.  For example,
reordering the arguments to map_matching_symbols has no relation to the
rest of the patch.  We normally make other contributors split such
patches.  I think it is best if maintainers do this as well.

Tom