Re: [RFA, doc RFA] Add "set debug symfile on".

[Doug Evans <dje@google.com>]

On Wed, Sep 25, 2013 at 12:57 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Doug" == Doug Evans <dje@google.com> writes:
>
> Doug> This patch adds a new debugging option: set debug symfile on
>
> Doug> For now it logs all calls through the symfile functions.
>
> Doug> Regression tested on amd64-linux.
>
> Doug> Ok to check in?
>
> It seems ok to me.
>
> This patch combines a few different things into one.  For example,
> reordering the arguments to map_matching_symbols has no relation to the
> rest of the patch.  We normally make other contributors split such
> patches.  I think it is best if maintainers do this as well.

I realize that. [And I figured you'd bring it up. :-)]

My argument is that for a small patch of this approx size I don't want
to impose on contributors *always* having to follow this rule.
One can reasonably counter with how can one know what the threshold
is, and that it would be more consistent to just always follow this
rule.
I guess this is one case where I'm a bit more wishy washy - it's a
time saver (and that's important!).
[As for time spent by the reviewer: for small enough patches any
incremental time is negligible IMO.]
To be clear, for larger patches I would indeed follow this rule (when
I remember to ... 1/2 :-)).

But no matter.  I'll put in the time to split it up and check it in that way.