From: Doug Evans <dje@google.com>
To: gdb-patches <gdb-patches@sourceware.org>, Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFA, doc RFA] Add "set debug symfile on".
Date: Wed, 25 Sep 2013 00:31:00 -0000 [thread overview]
Message-ID: <CADPb22STYUNMoncshO7jUzEHDYN6g=as14SC=jYUoe1YGCB=cw@mail.gmail.com> (raw)
In-Reply-To: <yjt261tpbvdj.fsf@ruffy.mtv.corp.google.com>
On Tue, Sep 24, 2013 at 5:25 PM, Doug Evans <dje@google.com> wrote:
> Hi.
>
> This patch adds a new debugging option: set debug symfile on
>
> For now it logs all calls through the symfile functions.
>
> Regression tested on amd64-linux.
>
> Ok to check in?
>
> 2013-09-24 Doug Evans <dje@google.com>
>
> New option "set debug symfile on".
> * NEWS: Mention "set debug symfile".
> * Makefile.in (SFILES): Add symfile-debug.c.
> (COMMON_OBS): Add sumfile-debug.o.
> * elfread.c (elf_symfile_read): Use objfile_set_sym_fns to set the
> objfile's symbol functions.
> * objfiles.h (objfile_set_sym_fns): Declare.
> * dwarf2read.c (dw2_map_matching_symbols): Update signature.
> * psymtab.c (map_matching_symbols_psymtab): Update signature.
> * symfile-debug.c: New file.
> * symfile.c (sym_fns_ptr): Delete. Replace with ...
> (registered_sym_fns): ... this.
> (symtab_fns): Update.
> (syms_from_objfile_1): Use objfile_set_sym_fns to set the objfile's
> symbol functions.
> (reread_symbols): Ditto.
> (add_symtab_fns): New arg "flavour". All callers updated.
> (find_sym_fns): Rewrite to use new sym_fns registry.
> * symfile.h (struct quick_symbol_functions): Reorg arg list of
> map_matching_symbols so objfile is first.
> (struct sym_fns): Delete member "sym_flavour". All uses updated.
> Add "objfile" argument to sym_read_linetable. All uses updated.
> (add_symtab_fns): Update prototype.
> * symtab.c (domain_name, search_domain_name): New functions.
> * symtab.h (domain_name, search_domain_name): Declare.
>
> doc/
> * gdb.texinfo (Debugging Output): Document set/show debug symfile.
Oh. Also tested with --enable-targets=all
next prev parent reply other threads:[~2013-09-25 0:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-25 0:25 Doug Evans
2013-09-25 0:31 ` Doug Evans [this message]
2013-09-25 5:57 ` Eli Zaretskii
2013-09-25 19:57 ` Tom Tromey
2013-09-25 21:03 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADPb22STYUNMoncshO7jUzEHDYN6g=as14SC=jYUoe1YGCB=cw@mail.gmail.com' \
--to=dje@google.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox