Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: lgustavo@codesourcery.com
Cc: "'gdb-patches\@sourceware.org'" <gdb-patches@sourceware.org>,
	       Pedro Alves <palves@redhat.com>
Subject: Re: [PATCH, v2] Share ptrace options discovery/linux native code between GDB and gdbserver
Date: Tue, 20 Aug 2013 15:38:00 -0000	[thread overview]
Message-ID: <87d2p8id9f.fsf@fleche.redhat.com> (raw)
In-Reply-To: <5212A9E1.6030707@codesourcery.com> (Luis Machado's message of	"Mon, 19 Aug 2013 20:27:29 -0300")

>>>>> "Luis" == Luis Machado <lgustavo@codesourcery.com> writes:

Luis> This is the second iteration of the patch to do some sharing of ptrace
Luis> and native linux stuff between GDB and gdbserver.

Luis> I've included fixes based on reviews, so hopefully this is in better
Luis> shape now.

Thanks.  I like it.  I have a few nits though.

Luis>           * common/linux-ptrace.c: Include nat/linux-waitpid.h.

I suppose at some point this file ought to be moved.

Luis>           * config.in (PTRACE_TYPE_ARG4): Undefine.

Usually for config.in I just write:

	* config.in: Rebuild.

... since presumably you just used autoheader.

Luis>           * configure.ac (AC_CACHE_CHECK): Add void * to the list of
Luis>           ptrace's 4th argument's types.
Luis>           Check the type of PTRACE_TYPE_ARG4.

AC_CACHE_CHECK isn't the right function name.  Perhaps no name is best
here.

Also, doesn't this check need to be done in gdbserver as well?

Tom


  reply	other threads:[~2013-08-20 15:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-19 23:27 Luis Machado
2013-08-20 15:38 ` Tom Tromey [this message]
2013-08-20 15:46   ` Luis Machado
2013-08-20 16:14     ` Tom Tromey
2013-08-20 16:39 ` Pedro Alves
2013-08-20 16:44   ` Pedro Alves
2013-08-20 16:48   ` Tom Tromey
2013-08-20 17:03     ` Pedro Alves
2013-08-21  3:09   ` Luis Machado
2013-08-21 21:29     ` Pedro Alves
2013-08-22  2:42       ` Luis Machado
2013-08-22 17:06         ` Pedro Alves
2013-08-22 18:02           ` Luis Machado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d2p8id9f.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=lgustavo@codesourcery.com \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox