From: Tom Tromey <tromey@redhat.com>
To: lgustavo@codesourcery.com
Cc: "'gdb-patches\@sourceware.org'" <gdb-patches@sourceware.org>,
Pedro Alves <palves@redhat.com>
Subject: Re: [PATCH, v2] Share ptrace options discovery/linux native code between GDB and gdbserver
Date: Tue, 20 Aug 2013 16:14:00 -0000 [thread overview]
Message-ID: <8761v0ibl7.fsf@fleche.redhat.com> (raw)
In-Reply-To: <52138F32.3020601@codesourcery.com> (Luis Machado's message of "Tue, 20 Aug 2013 12:45:54 -0300")
>>>>> "Luis" == Luis Machado <lgustavo@codesourcery.com> writes:
Luis> Right. Should i move it now as part of this cleanup or should i move
Luis> it in a follow up?
Probably preferable as a follow-up.
Or a prequel.
>> Also, doesn't this check need to be done in gdbserver as well?
Luis> For gdbserver we explicitly define the correct types for each argument.
Ok, I see.
Luis> Since this is a runtime check, we may run into issues if we attempt to
Luis> run a binary on a build machine if the target machine is from a
Luis> different architecture. Does it make sense?
I looks like an AC_TRY_COMPILE check to me. That means it is safe.
However, if it isn't needed for gdbserver, then the point is moot.
Tom
next prev parent reply other threads:[~2013-08-20 16:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-19 23:27 Luis Machado
2013-08-20 15:38 ` Tom Tromey
2013-08-20 15:46 ` Luis Machado
2013-08-20 16:14 ` Tom Tromey [this message]
2013-08-20 16:39 ` Pedro Alves
2013-08-20 16:44 ` Pedro Alves
2013-08-20 16:48 ` Tom Tromey
2013-08-20 17:03 ` Pedro Alves
2013-08-21 3:09 ` Luis Machado
2013-08-21 21:29 ` Pedro Alves
2013-08-22 2:42 ` Luis Machado
2013-08-22 17:06 ` Pedro Alves
2013-08-22 18:02 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8761v0ibl7.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=lgustavo@codesourcery.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox