From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: lgustavo@codesourcery.com,
"'gdb-patches\@sourceware.org'"
<gdb-patches@sourceware.org>
Subject: Re: [PATCH, v2] Share ptrace options discovery/linux native code between GDB and gdbserver
Date: Tue, 20 Aug 2013 16:48:00 -0000 [thread overview]
Message-ID: <871u5oia03.fsf@fleche.redhat.com> (raw)
In-Reply-To: <52139BBA.60300@redhat.com> (Pedro Alves's message of "Tue, 20 Aug 2013 17:39:22 +0100")
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>> +void
>> +linux_enable_event_reporting (ptid_t ptid)
Pedro> Could you preserve gdbserver's prototype here, please? That
Pedro> is, take a single integer pid rather than a ptid.
Just a nit -- but why int and not pid_t?
(Not a typo for ptid_t, that one I understand :)
Tom
next prev parent reply other threads:[~2013-08-20 16:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-19 23:27 Luis Machado
2013-08-20 15:38 ` Tom Tromey
2013-08-20 15:46 ` Luis Machado
2013-08-20 16:14 ` Tom Tromey
2013-08-20 16:39 ` Pedro Alves
2013-08-20 16:44 ` Pedro Alves
2013-08-20 16:48 ` Tom Tromey [this message]
2013-08-20 17:03 ` Pedro Alves
2013-08-21 3:09 ` Luis Machado
2013-08-21 21:29 ` Pedro Alves
2013-08-22 2:42 ` Luis Machado
2013-08-22 17:06 ` Pedro Alves
2013-08-22 18:02 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871u5oia03.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=lgustavo@codesourcery.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox