From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25003 invoked by alias); 20 Aug 2013 16:48:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24994 invoked by uid 89); 20 Aug 2013 16:48:33 -0000 X-Spam-SWARE-Status: No, score=-7.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 20 Aug 2013 16:48:32 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7KGmUjC012426 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 20 Aug 2013 12:48:30 -0400 Received: from barimba (ovpn-113-142.phx2.redhat.com [10.3.113.142]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r7KGmTBk006226 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 20 Aug 2013 12:48:30 -0400 From: Tom Tromey To: Pedro Alves Cc: lgustavo@codesourcery.com, "'gdb-patches\@sourceware.org'" Subject: Re: [PATCH, v2] Share ptrace options discovery/linux native code between GDB and gdbserver References: <5212A9E1.6030707@codesourcery.com> <52139BBA.60300@redhat.com> Date: Tue, 20 Aug 2013 16:48:00 -0000 In-Reply-To: <52139BBA.60300@redhat.com> (Pedro Alves's message of "Tue, 20 Aug 2013 17:39:22 +0100") Message-ID: <871u5oia03.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-08/txt/msg00550.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: >> +void >> +linux_enable_event_reporting (ptid_t ptid) Pedro> Could you preserve gdbserver's prototype here, please? That Pedro> is, take a single integer pid rather than a ptid. Just a nit -- but why int and not pid_t? (Not a typo for ptid_t, that one I understand :) Tom