From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29207 invoked by alias); 20 Aug 2013 15:38:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29189 invoked by uid 89); 20 Aug 2013 15:38:10 -0000 X-Spam-SWARE-Status: No, score=-7.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 20 Aug 2013 15:38:09 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7KFc5An000618 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 20 Aug 2013 11:38:06 -0400 Received: from barimba (ovpn-113-142.phx2.redhat.com [10.3.113.142]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r7KFc43Z030728 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 20 Aug 2013 11:38:05 -0400 From: Tom Tromey To: lgustavo@codesourcery.com Cc: "'gdb-patches\@sourceware.org'" , Pedro Alves Subject: Re: [PATCH, v2] Share ptrace options discovery/linux native code between GDB and gdbserver References: <5212A9E1.6030707@codesourcery.com> Date: Tue, 20 Aug 2013 15:38:00 -0000 In-Reply-To: <5212A9E1.6030707@codesourcery.com> (Luis Machado's message of "Mon, 19 Aug 2013 20:27:29 -0300") Message-ID: <87d2p8id9f.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-08/txt/msg00543.txt.bz2 >>>>> "Luis" == Luis Machado writes: Luis> This is the second iteration of the patch to do some sharing of ptrace Luis> and native linux stuff between GDB and gdbserver. Luis> I've included fixes based on reviews, so hopefully this is in better Luis> shape now. Thanks. I like it. I have a few nits though. Luis> * common/linux-ptrace.c: Include nat/linux-waitpid.h. I suppose at some point this file ought to be moved. Luis> * config.in (PTRACE_TYPE_ARG4): Undefine. Usually for config.in I just write: * config.in: Rebuild. ... since presumably you just used autoheader. Luis> * configure.ac (AC_CACHE_CHECK): Add void * to the list of Luis> ptrace's 4th argument's types. Luis> Check the type of PTRACE_TYPE_ARG4. AC_CACHE_CHECK isn't the right function name. Perhaps no name is best here. Also, doesn't this check need to be done in gdbserver as well? Tom