Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Guinevere Larsen <guinevere@redhat.com>
Cc: Tom Tromey <tom@tromey.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: fix filename matching in skiplist_entry::do_skip_gfile_p
Date: Wed, 04 Feb 2026 08:26:55 -0700	[thread overview]
Message-ID: <87cy2k7cn4.fsf@tromey.com> (raw)
In-Reply-To: <71556744-0b46-4d56-acb4-11ded5854eb8@redhat.com> (Guinevere Larsen's message of "Tue, 3 Feb 2026 15:55:15 -0300")

>>>>> "Guinevere" == Guinevere Larsen <guinevere@redhat.com> writes:

Guinevere> result = gdb_filename_fnmatch
Guinevere>                 (m_file.c_str (), fullname, FNM_NOESCAPE) == 0;

Guinevere> I find that much prettier, if it is alright with our coding style

This isn't really the style either I'm afraid.
See https://www.gnu.org/prep/standards/standards.html#Formatting


Tom

  reply	other threads:[~2026-02-04 15:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-02 20:34 Guinevere Larsen
2026-02-02 21:46 ` Andrew Burgess
2026-02-03 14:27 ` Tom Tromey
2026-02-03 18:55   ` Guinevere Larsen
2026-02-04 15:26     ` Tom Tromey [this message]
2026-02-04 16:13       ` Guinevere Larsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cy2k7cn4.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=guinevere@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox