From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id au9AOV1lg2mkPigAWB0awg (envelope-from ) for ; Wed, 04 Feb 2026 10:27:25 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=sSBgKrSf; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D6EEC1E08D; Wed, 04 Feb 2026 10:27:25 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,RDNS_NONE autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (unknown [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0E5DF1E08D for ; Wed, 04 Feb 2026 10:27:25 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 8F2864BA2E16 for ; Wed, 4 Feb 2026 15:27:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8F2864BA2E16 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=sSBgKrSf Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id 80BED4BA2E08 for ; Wed, 4 Feb 2026 15:26:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 80BED4BA2E08 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 80BED4BA2E08 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770218818; cv=none; b=qQ2qT6YGFG2oAU6GkmcNpG4VmX65L3PFndfHUr/AVcxHYB60/2qslmbIYGUIxwd1IPaNn1eSZk5702M0IL4YK5ttLo0dUBQMIXhzeMeBdPkYzTI9FPGV0kKpVDawMzZ3FFBobZGX1QPrbRUxclLs0hBlkqSBsQhQ+LX+Gwd6PEY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770218818; c=relaxed/simple; bh=I0vGgQ3FwyZBBiOf4rRLd9pWinxA6kzFthvHLTgI9Hw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=FfBWm3KgwLFNDY2bm8V7pzsH3X0nYGoOKJ1DC0Q289wC2BfIzUgOGr3tk+ABf5IMkglp4g3qyOSZvb3dx5izFxBxLPpe9DKwIDXz9iKSQh8tsBgCDRYJ6s5G+QiQvflSZqSLJe+6Jmj4F8iWIlQQmgyMqkMJq4Dny5i6SOzC9PA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 80BED4BA2E08 Received: from eig-obgw-5006b.ext.cloudfilter.net ([10.0.29.217]) by cmsmtp with ESMTPS id nbYBvoVGQKjfonemPvRrYa; Wed, 04 Feb 2026 15:26:57 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id nemOvjFjROs9RnemPvqDW4; Wed, 04 Feb 2026 15:26:57 +0000 X-Authority-Analysis: v=2.4 cv=HPPDFptv c=1 sm=1 tr=0 ts=69836541 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=ItBw4LHWJt0A:10 a=mDV3o1hIAAAA:8 a=20KFwNOVAAAA:8 a=vzf-lTmpDfQB7n_IRMMA:9 a=QEXdDO2ut3YA:10 a=XvDEu3d0nPYA:10 a=eLk5gG4gwo8A:10 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=I0vGgQ3FwyZBBiOf4rRLd9pWinxA6kzFthvHLTgI9Hw=; b=sSBgKrSfrKvSvPDisgaxfpD25g 3f4o4sJCkZB9ql6v5FTR2qEvcTU2IUDHTfxuBtkxOLoG+J+HKLtnpJdtXaSisYFWaFfAzI+6V4/jo 9e5zyZF3pd2Aqahp6bzQC1cPr; Received: from 97-118-49-200.hlrn.qwest.net ([97.118.49.200]:44574 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vnemO-00000003mYx-1lQa; Wed, 04 Feb 2026 08:26:56 -0700 From: Tom Tromey To: Guinevere Larsen Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: fix filename matching in skiplist_entry::do_skip_gfile_p In-Reply-To: <71556744-0b46-4d56-acb4-11ded5854eb8@redhat.com> (Guinevere Larsen's message of "Tue, 3 Feb 2026 15:55:15 -0300") References: <20260202203404.708144-1-guinevere@redhat.com> <87sebh7vhh.fsf@tromey.com> <71556744-0b46-4d56-acb4-11ded5854eb8@redhat.com> X-Attribution: Tom Date: Wed, 04 Feb 2026 08:26:55 -0700 Message-ID: <87cy2k7cn4.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.118.49.200 X-Source-L: No X-Exim-ID: 1vnemO-00000003mYx-1lQa X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-118-49-200.hlrn.qwest.net (bapiya) [97.118.49.200]:44574 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfIbgEXvn4G+TBCTJnQ59kZuEefGydofFxBOEqfK225Icxsl7gz74Yeh9FOFflOWoirgoNL9nKelhP/NxcKSc+lV1YyardCyRqjUFB+XFw3oCMarazLFx jBFQQw7yH3feiRueoMSVVQ0rZsmU8A9fIRq0M5mLmSgbgfnF+y5IAjrZcmvHjFHOJJ96OrqpbEgbn0XWYGSRGtjssl8OlaqFq5Y= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Guinevere" =3D=3D Guinevere Larsen writes: Guinevere> result =3D gdb_filename_fnmatch Guinevere> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (m_file.= c_str (), fullname, FNM_NOESCAPE) =3D=3D 0; Guinevere> I find that much prettier, if it is alright with our coding style This isn't really the style either I'm afraid. See https://www.gnu.org/prep/standards/standards.html#Formatting Tom