From: Guinevere Larsen <guinevere@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: fix filename matching in skiplist_entry::do_skip_gfile_p
Date: Wed, 4 Feb 2026 13:13:21 -0300 [thread overview]
Message-ID: <a0812e30-d6c7-4ee5-8b80-3cafeac696f7@redhat.com> (raw)
In-Reply-To: <87cy2k7cn4.fsf@tromey.com>
On 2/4/26 12:26 PM, Tom Tromey wrote:
>>>>>> "Guinevere" == Guinevere Larsen <guinevere@redhat.com> writes:
> Guinevere> result = gdb_filename_fnmatch
> Guinevere> (m_file.c_str (), fullname, FNM_NOESCAPE) == 0;
>
> Guinevere> I find that much prettier, if it is alright with our coding style
>
> This isn't really the style either I'm afraid.
> See https://www.gnu.org/prep/standards/standards.html#Formatting
>
>
> Tom
>
Oh sorry. Will update it to
result = gdb_filename_fnmatch (m_file.c_str (), fullname,
FNM_NOESCAPE) == 0;
I just want to avoid having a super long line and a tiny line following
it. If this one still isn't ok, I'll go with your original suggestion...
--
Cheers,
Guinevere Larsen
It/she
prev parent reply other threads:[~2026-02-04 16:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 20:34 Guinevere Larsen
2026-02-02 21:46 ` Andrew Burgess
2026-02-03 14:27 ` Tom Tromey
2026-02-03 18:55 ` Guinevere Larsen
2026-02-04 15:26 ` Tom Tromey
2026-02-04 16:13 ` Guinevere Larsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0812e30-d6c7-4ee5-8b80-3cafeac696f7@redhat.com \
--to=guinevere@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox