From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id nz4dMEVwg2lwTSgAWB0awg (envelope-from ) for ; Wed, 04 Feb 2026 11:13:57 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=XXBBDr74; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B76A61E08D; Wed, 04 Feb 2026 11:13:57 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED,RDNS_NONE autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (unknown [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D74131E08D for ; Wed, 04 Feb 2026 11:13:55 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 669954BA2E0D for ; Wed, 4 Feb 2026 16:13:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 669954BA2E0D Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=XXBBDr74 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 30D4A4BA543C for ; Wed, 4 Feb 2026 16:13:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 30D4A4BA543C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 30D4A4BA543C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770221610; cv=none; b=Ji9a+Mw6fPy7YuX15hE50kEGPR1JN5D5Ey3HI7Vf/6CbHo64DEFZgVCzytc5TPT8RGCmNYHACKj5DHlDtZsAxGMgNT+0IIjMw4rCGJKxrM5KggbUNA1yKlm/AdnU88Y3H0CtM51aiEMnoV+lgIHoRi1cIikrst4ay6z1N2ukw/M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770221610; c=relaxed/simple; bh=RULg0uKb1T8ypAefBCLlNFRJ2VfB7SgLFXjxjaN5jWk=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=bZ+L3F6zJWqsd8Xkoe7mnLOuPv1Hc8lA377lgH122/kUoq/Bg1xQLOUdpX48aVZpBDUu1WTlRNk3V41d6Vkd2n9t4If/LFf3m69tRWv5sImwLekwrcpbdpbSfXX3e6Hj2XwHuY7Y6Fyw1E0S69nPhl0Z8HeByqgb/PJP89ICiXM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 30D4A4BA543C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770221609; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TwlhVnIyjlQfAWivzHILmeCwk/GK2vAt70VUCePZOnw=; b=XXBBDr745h0TIvKR+l7Ht1Kd50/SXyuTibuLk0IdUxYl7MokuCGl6XjFWN348sJV2Raz9P RuJUbDtq5omzb+O14aU4rK76z0A3CyUzXg7bJ5Ssi3cBLWKnOB+6SWVXZs+VXeyteM0Kjh c7i/UBhFAVqPs0GC+48d4mD+a9jzmtE= Received: from mail-dl1-f72.google.com (mail-dl1-f72.google.com [74.125.82.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-517-hDFz_HsdPkicdPMfXk-TUw-1; Wed, 04 Feb 2026 11:13:28 -0500 X-MC-Unique: hDFz_HsdPkicdPMfXk-TUw-1 X-Mimecast-MFC-AGG-ID: hDFz_HsdPkicdPMfXk-TUw_1770221607 Received: by mail-dl1-f72.google.com with SMTP id a92af1059eb24-12337114f3fso64008c88.0 for ; Wed, 04 Feb 2026 08:13:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770221607; x=1770826407; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TwlhVnIyjlQfAWivzHILmeCwk/GK2vAt70VUCePZOnw=; b=p6KujAi+d4H0giOwea/r81pgdSfeZaHm/OpW3KMdSl8bD/L1a5dsKpsiWHz81xRfLr L/0O++xbSu8I1NmG3qfWFwxtP8dPd4uiF0tSqL1oGXaUcGHojkbsw4ukCA0/cqaqu6Vk FB5Swax39OY6M1gL8C94JSKk6NdOrhOJJF+rHlPUBGI42qb2TVRZtAKE7p71ojDq3l4k j5xXlQHgOTetnzlHp+zgP1DkgQsko69wh+obJqGrk5GetQH2Aqp2o+6zqhMElmh3ReM9 mnG5awzWPoFasA/vvjb3faEZbJETEcozImrUg45pJ8NCsJVkaO/CsLFjBkN8Rr6nbgBA /WSg== X-Gm-Message-State: AOJu0YxeG9w4wkCPJXgeJNRaUUmORBM9H2G3xxpSejJoa0ilj77ImZ+7 MquLvp/weN0DJOQqmr6nU0/vZBLWVHQneJDXc5FamegvZfcFd1cPJVfwpwRSZXfHRBQlvTyrdMx G128c/EBdvP6xa54S3xfNrDNdLbqCg7jHn1vTL9t5nUnSs0Mb6whWzkWNDxYo8O2xXEm4mvY= X-Gm-Gg: AZuq6aItwhqSxGYDsytlIkSEea1H+A41yISk8A01iNNOM2ycGx8wU4iaKd+NjXZFJy3 tgrF+/fjnyxruYn0kzO/NEhj8YiHpw+YhOyR9YtNzR8VoF9frFB1cxiUHRfFxpw54sQsfwbjNW/ S1yNrTkYVuHNfZQRvXA9tVS00f36I+/KzCwJPO/5V/0gCXjhEDMP3ZCcK1C2Jd0Z7PTQSKtYbKU QtbKrdnYxOxZS/1ZgMWdhwVU0p/3uLKhBk/rhMWanD/QKaJQbt6HFdpGhZq7krqAaqkwZztiqs4 c3sPipLVRKc19dmespntxm7JT70epr5cqxFCY1s5CTeSIlo6Ks3QmkpZ+Z6CGlzg8/YQ1kV8eSH mQGPdVRfKZZbOw0PNL2v8qA== X-Received: by 2002:a05:7022:b98:b0:124:9fd8:4ba9 with SMTP id a92af1059eb24-126f477dd1cmr1216429c88.12.1770221606844; Wed, 04 Feb 2026 08:13:26 -0800 (PST) X-Received: by 2002:a05:7022:b98:b0:124:9fd8:4ba9 with SMTP id a92af1059eb24-126f477dd1cmr1216419c88.12.1770221606344; Wed, 04 Feb 2026 08:13:26 -0800 (PST) Received: from ?IPV6:2804:14d:8084:a5b1::1000? ([2804:14d:8084:a5b1::1000]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-126f4e042bfsm2293853c88.4.2026.02.04.08.13.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Feb 2026 08:13:25 -0800 (PST) Message-ID: Date: Wed, 4 Feb 2026 13:13:21 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb: fix filename matching in skiplist_entry::do_skip_gfile_p To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260202203404.708144-1-guinevere@redhat.com> <87sebh7vhh.fsf@tromey.com> <71556744-0b46-4d56-acb4-11ded5854eb8@redhat.com> <87cy2k7cn4.fsf@tromey.com> From: Guinevere Larsen In-Reply-To: <87cy2k7cn4.fsf@tromey.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Jyl0QhUPcKS9CNZZVfUuZ49KQmr6GpO8DmlVUGWQ9Zg_1770221607 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2/4/26 12:26 PM, Tom Tromey wrote: >>>>>> "Guinevere" == Guinevere Larsen writes: > Guinevere> result = gdb_filename_fnmatch > Guinevere>                 (m_file.c_str (), fullname, FNM_NOESCAPE) == 0; > > Guinevere> I find that much prettier, if it is alright with our coding style > > This isn't really the style either I'm afraid. > See https://www.gnu.org/prep/standards/standards.html#Formatting > > > Tom > Oh sorry. Will update it to result = gdb_filename_fnmatch (m_file.c_str (), fullname, FNM_NOESCAPE) == 0; I just want to avoid having a super long line and a tiny line following it. If this one still isn't ok, I'll go with your original suggestion... -- Cheers, Guinevere Larsen It/she