Re: [PATCH] gdb: fix filename matching in skiplist_entry::do_skip_gfile_p

Guinevere Larsen
2026-02-03T18:56:07Z

On 2/3/26 11:27 AM, Tom Tromey wrote:
>>>>>> "Guinevere" == Guinevere Larsen <guinevere@redhat.com> writes:
> Guinevere> - result = gdb_filename_fnmatch (m_file.c_str (), fullname, FNM_NOESCAPE);
> Guinevere> + result = gdb_filename_fnmatch (m_file.c_str (), fullname, FNM_NOESCAPE)
> Guinevere> + == 0;
>
> Wrapped expressions like this need the RHS parenthesized.
>
> thanks,
> Tom
>
I ended up changing it to

result = gdb_filename_fnmatch
(m_file.c_str (), fullname, FNM_NOESCAPE) == 0;

I find that much prettier, if it is alright with our coding style

--
Cheers,
Guinevere Larsen
It/she