Re: [PATCH] gdb: fix filename matching in skiplist_entry::do_skip_gfile_p

Guinevere Larsen
2026-02-04T16:13:57Z

On 2/4/26 12:26 PM, Tom Tromey wrote:
>>>>>> "Guinevere" == Guinevere Larsen <guinevere@redhat.com> writes:
> Guinevere> result = gdb_filename_fnmatch
> Guinevere>                 (m_file.c_str (), fullname, FNM_NOESCAPE) == 0;
>
> Guinevere> I find that much prettier, if it is alright with our coding style
>
> This isn't really the style either I'm afraid.
> See https://www.gnu.org/prep/standards/standards.html#Formatting
>
>
> Tom
>
Oh sorry. Will update it to

result = gdb_filename_fnmatch (m_file.c_str (), fullname,
FNM_NOESCAPE) == 0;

I just want to avoid having a super long line and a tiny line following
it. If this one still isn't ok, I'll go with your original suggestion...

--
Cheers,
Guinevere Larsen
It/she