Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] gdb: Add a find method for RegisterDescriptorIterator
Date: Fri, 24 Jul 2020 12:22:55 -0600	[thread overview]
Message-ID: <87a6zodb7k.fsf@tromey.com> (raw)
In-Reply-To: <be3ee9b06bd5f820a99d2293bc3a36c018670b0d.1595584512.git.andrew.burgess@embecosm.com> (Andrew Burgess's message of "Fri, 24 Jul 2020 10:57:51 +0100")

>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:

Andrew> Adds a new method 'find' to the gdb.RegisterDescriptorIterator class,
Andrew> this allows gdb.RegisterDescriptor objects to be looked up directly by
Andrew> register name rather than having to iterate over all registers.

Andrew> This will be of use for a later commit.

Andrew> I've documented the new function in the manual, but I don't think a
Andrew> NEWS entry is required here, as, since the last release, the whole
Andrew> register descriptor mechanism is new, and is already mentioned in the
Andrew> NEWS file.

Andrew> gdb/ChangeLog:

Andrew> 	* python/py-registers.c: Add 'user-regs.h' include.
Andrew> 	(register_descriptor_iter_find): New function.
Andrew> 	(register_descriptor_iterator_object_methods): New static global
Andrew> 	methods array.
Andrew> 	(register_descriptor_iterator_object_type): Add pointer to methods
Andrew> 	array.

Thanks for doing this.  This looks good.

Tom


  parent reply	other threads:[~2020-07-24 18:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-24  9:57 [PATCH 0/2] Allow gdb.RegisterDescriptors to be used in read_register calls Andrew Burgess
2020-07-24  9:57 ` [PATCH 1/2] gdb: Add a find method for RegisterDescriptorIterator Andrew Burgess
2020-07-24 10:32   ` Eli Zaretskii
2020-07-24 23:17     ` Andrew Burgess
2020-07-25  6:27       ` Eli Zaretskii
2020-07-24 18:22   ` Tom Tromey [this message]
2020-07-24  9:57 ` [PATCH 2/2] gdb/python: make more use of RegisterDescriptors Andrew Burgess
2020-07-24 10:36   ` Eli Zaretskii
2020-07-24 18:38   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6zodb7k.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox