From: Eli Zaretskii <eliz@gnu.org>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] gdb/python: make more use of RegisterDescriptors
Date: Fri, 24 Jul 2020 13:36:41 +0300 [thread overview]
Message-ID: <83lfj9dwsm.fsf@gnu.org> (raw)
In-Reply-To: <ec85a6d5476012b0fc59192039e8d1fbff029d15.1595584512.git.andrew.burgess@embecosm.com> (message from Andrew Burgess on Fri, 24 Jul 2020 10:57:52 +0100)
> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Date: Fri, 24 Jul 2020 10:57:52 +0100
>
> +A @code{gdb.RegisterDescriptor} object, see @ref{Registers In Python}
> +for further information.
Please add a comma after the closing brace of @ref. Newer versions of
Texinfo don't need that, but older ones will barf.
> +@item
> +A @value{GDBN} internal, platform specific number. Using these
> +numbers is supported for historic reasons, but is not recommended as
> +future changes to @value{GDBN} could change the mapping between numbers
> +and the registers they represent, breaking any Python code. The
I suggest "breaking any Python code that uses the platform-specific
numbers", to qualify the breakage.
The documentation part is okay with these nits fixed. Thanks.
next prev parent reply other threads:[~2020-07-24 10:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 9:57 [PATCH 0/2] Allow gdb.RegisterDescriptors to be used in read_register calls Andrew Burgess
2020-07-24 9:57 ` [PATCH 1/2] gdb: Add a find method for RegisterDescriptorIterator Andrew Burgess
2020-07-24 10:32 ` Eli Zaretskii
2020-07-24 23:17 ` Andrew Burgess
2020-07-25 6:27 ` Eli Zaretskii
2020-07-24 18:22 ` Tom Tromey
2020-07-24 9:57 ` [PATCH 2/2] gdb/python: make more use of RegisterDescriptors Andrew Burgess
2020-07-24 10:36 ` Eli Zaretskii [this message]
2020-07-24 18:38 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83lfj9dwsm.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox