Re: [PATCH 2/2] gdb/python: make more use of RegisterDescriptors

[Tom Tromey <tom@tromey.com>]

>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:

Andrew> This commit unifies all of the Python register lookup code (used by
Andrew> Frame.read_register, PendingFrame.read_register, and
Andrew> gdb.UnwindInfo.add_saved_register), and adds support for using a
Andrew> gdb.RegisterDescriptor for register lookup.

Thanks for doing this.  This approach seems good to me.

Andrew> +other two methods as @value{GDBN} must lookup the mapping between name

I'd suggest "look up" here.

Andrew> +/* See python-internal.h.  */
Andrew> +
Andrew> +bool
Andrew> +gdbpy_parse_register_id (struct gdbarch *gdbarch, PyObject *pyo_reg_id,
Andrew> +			 int *reg_num)
Andrew> +{
Andrew> +  if (pyo_reg_id == NULL)
Andrew> +    return false;

I think this function should consistently set the Python error when
returning false.

Andrew> +  if (gdbpy_is_string (pyo_reg_id))
Andrew> +    {
Andrew> +      gdb::unique_xmalloc_ptr<char> reg_name (gdbpy_obj_to_string (pyo_reg_id));

... gdbpy_obj_to_string will set the Python error when it returns NULL.

Andrew> +      if (gdb_py_int_as_long (pyo_reg_id, &value) && (int) value == value)

gdb_py_int_as_long can set the error as well.

Tom