From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway21.websitewelcome.com (gateway21.websitewelcome.com [192.185.45.250]) by sourceware.org (Postfix) with ESMTPS id 50A363857C64 for ; Fri, 24 Jul 2020 18:38:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 50A363857C64 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway21.websitewelcome.com (Postfix) with ESMTP id B91EF400C7FD9 for ; Fri, 24 Jul 2020 13:38:23 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id z2aNjqeEmQyTQz2aNjVjeO; Fri, 24 Jul 2020 13:38:23 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=4A11f4oCAgnc5ANDHnpyE8/buaJqgDujS1m1sxTBX+0=; b=Dbx9UW6pSzWV1r8Mff3yz4ig3g WwnFm1Ynq2ZG9XKqPGUNUikmYTsKf6uKDIzjT+8Mufx52cA2FUsPTVhJCZAxuccv2w6kUfLdO0PXI h5uanKI8nT2d2sp7QjBAbf4UL; Received: from 174-16-104-48.hlrn.qwest.net ([174.16.104.48]:39628 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jz2aN-003rr8-8X; Fri, 24 Jul 2020 12:38:23 -0600 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] gdb/python: make more use of RegisterDescriptors References: X-Attribution: Tom Date: Fri, 24 Jul 2020 12:38:21 -0600 In-Reply-To: (Andrew Burgess's message of "Fri, 24 Jul 2020 10:57:52 +0100") Message-ID: <87365gdahu.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.104.48 X-Source-L: No X-Exim-ID: 1jz2aN-003rr8-8X X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-104-48.hlrn.qwest.net (murgatroyd) [174.16.104.48]:39628 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3025.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_SBL_CSS, SPF_HELO_PASS, SPF_NEUTRAL, TXREP, URIBL_CSS, URIBL_CSS_A autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jul 2020 18:38:25 -0000 >>>>> "Andrew" == Andrew Burgess writes: Andrew> This commit unifies all of the Python register lookup code (used by Andrew> Frame.read_register, PendingFrame.read_register, and Andrew> gdb.UnwindInfo.add_saved_register), and adds support for using a Andrew> gdb.RegisterDescriptor for register lookup. Thanks for doing this. This approach seems good to me. Andrew> +other two methods as @value{GDBN} must lookup the mapping between name I'd suggest "look up" here. Andrew> +/* See python-internal.h. */ Andrew> + Andrew> +bool Andrew> +gdbpy_parse_register_id (struct gdbarch *gdbarch, PyObject *pyo_reg_id, Andrew> + int *reg_num) Andrew> +{ Andrew> + if (pyo_reg_id == NULL) Andrew> + return false; I think this function should consistently set the Python error when returning false. Andrew> + if (gdbpy_is_string (pyo_reg_id)) Andrew> + { Andrew> + gdb::unique_xmalloc_ptr reg_name (gdbpy_obj_to_string (pyo_reg_id)); ... gdbpy_obj_to_string will set the Python error when it returns NULL. Andrew> + if (gdb_py_int_as_long (pyo_reg_id, &value) && (int) value == value) gdb_py_int_as_long can set the error as well. Tom