From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway23.websitewelcome.com (gateway23.websitewelcome.com [192.185.48.104]) by sourceware.org (Postfix) with ESMTPS id 90535385703C for ; Fri, 24 Jul 2020 18:25:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 90535385703C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 050E92E40E4 for ; Fri, 24 Jul 2020 13:24:57 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id z2LQj043KBb5dz2LQjj1Xq; Fri, 24 Jul 2020 13:22:56 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=9plL/IAu/enYVtJDHxUpbmv28HVQkPvKTl2d/w2i5K4=; b=NaQ9Ubr/k7uAe/31gjAJU8PCvX Y59N2Xa3CHBdNhIXsxTSxVv2XrapDl+X6PLYX13ARtxacXsR0GDFy/iT4xUOMYcDTnieeKAoUv88E mp5bk0J/BpbUFz+Ro2ypMF4Ud; Received: from 174-16-104-48.hlrn.qwest.net ([174.16.104.48]:39350 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jz2LQ-003kbt-HH; Fri, 24 Jul 2020 12:22:56 -0600 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] gdb: Add a find method for RegisterDescriptorIterator References: X-Attribution: Tom Date: Fri, 24 Jul 2020 12:22:55 -0600 In-Reply-To: (Andrew Burgess's message of "Fri, 24 Jul 2020 10:57:51 +0100") Message-ID: <87a6zodb7k.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.104.48 X-Source-L: No X-Exim-ID: 1jz2LQ-003kbt-HH X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-104-48.hlrn.qwest.net (murgatroyd) [174.16.104.48]:39350 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3025.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_SBL_CSS, SPF_HELO_PASS, SPF_NEUTRAL, TXREP, URIBL_CSS, URIBL_CSS_A autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jul 2020 18:25:20 -0000 >>>>> "Andrew" == Andrew Burgess writes: Andrew> Adds a new method 'find' to the gdb.RegisterDescriptorIterator class, Andrew> this allows gdb.RegisterDescriptor objects to be looked up directly by Andrew> register name rather than having to iterate over all registers. Andrew> This will be of use for a later commit. Andrew> I've documented the new function in the manual, but I don't think a Andrew> NEWS entry is required here, as, since the last release, the whole Andrew> register descriptor mechanism is new, and is already mentioned in the Andrew> NEWS file. Andrew> gdb/ChangeLog: Andrew> * python/py-registers.c: Add 'user-regs.h' include. Andrew> (register_descriptor_iter_find): New function. Andrew> (register_descriptor_iterator_object_methods): New static global Andrew> methods array. Andrew> (register_descriptor_iterator_object_type): Add pointer to methods Andrew> array. Thanks for doing this. This looks good. Tom