Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: Handle ICC's unexpected void return type
Date: Tue, 06 Nov 2018 18:11:00 -0000	[thread overview]
Message-ID: <878t26rs9a.fsf@tromey.com> (raw)
In-Reply-To: <20181023212843.4774-1-andrew.burgess@embecosm.com> (Andrew	Burgess's message of "Tue, 23 Oct 2018 22:28:43 +0100")

>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:

Andrew> I encountered a binary compiled with Intel's C Compiler version
Andrew> 14.0.5.212, which seemed to contain some non-standard DWARF.
[...]

Andrew> A test confirms that the issue is fixed.

Thanks for this test.  It's very good to have these; in the past I think
some compiler workarounds have gone in without such tests, and then
later it is difficult to figure out whether changes keep gdb working.

Andrew> +	if (bits == 0 && producer_is_icc (cu)
Andrew> +	    && strcmp (name, "void") == 0)

I think NAME can be null here, so an additional check is needed to avoid
a potential crash.

Tom


  parent reply	other threads:[~2018-11-06 18:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-23 21:28 Andrew Burgess
2018-10-24 17:10 ` Kevin Buettner
2018-10-24 21:00 ` Keith Seitz
2018-10-31  0:23   ` Andrew Burgess
2018-10-31  0:34     ` Keith Seitz
2018-10-31  3:26       ` Kevin Buettner
2018-11-06 18:11 ` Tom Tromey [this message]
2018-11-06 20:43   ` Andrew Burgess
2018-11-06 22:42     ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878t26rs9a.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox