From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Cc: Andrew Burgess <andrew.burgess@embecosm.com>
Subject: Re: [PATCH] gdb: Handle ICC's unexpected void return type
Date: Wed, 24 Oct 2018 17:10:00 -0000 [thread overview]
Message-ID: <20181024101044.2ca491db@pinnacle.lan> (raw)
In-Reply-To: <20181023212843.4774-1-andrew.burgess@embecosm.com>
Hi Andrew,
Mostly okay, just a two nits...
On Tue, 23 Oct 2018 22:28:43 +0100
Andrew Burgess <andrew.burgess@embecosm.com> wrote:
> diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
> index 2a1b805c9a7..7d9026a59d7 100644
> --- a/gdb/dwarf2read.c
> +++ b/gdb/dwarf2read.c
> @@ -551,6 +551,7 @@ struct dwarf2_cu
> unsigned int checked_producer : 1;
> unsigned int producer_is_gxx_lt_4_6 : 1;
> unsigned int producer_is_gcc_lt_4_3 : 1;
> + unsigned int producer_is_icc : 1;
Use bool here like the recently added producer_is_codewarrior.
And...
> @@ -25134,6 +25155,7 @@ dwarf2_cu::dwarf2_cu (struct dwarf2_per_cu_data *per_cu_)
> checked_producer (0),
> producer_is_gxx_lt_4_6 (0),
> producer_is_gcc_lt_4_3 (0),
> + producer_is_icc (0),
Use false instead of 0.
Kevin
next prev parent reply other threads:[~2018-10-24 17:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 21:28 Andrew Burgess
2018-10-24 17:10 ` Kevin Buettner [this message]
2018-10-24 21:00 ` Keith Seitz
2018-10-31 0:23 ` Andrew Burgess
2018-10-31 0:34 ` Keith Seitz
2018-10-31 3:26 ` Kevin Buettner
2018-11-06 18:11 ` Tom Tromey
2018-11-06 20:43 ` Andrew Burgess
2018-11-06 22:42 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181024101044.2ca491db@pinnacle.lan \
--to=kevinb@redhat.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox