From: Kevin Buettner <kevinb@redhat.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: Keith Seitz <keiths@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: Handle ICC's unexpected void return type
Date: Wed, 31 Oct 2018 03:26:00 -0000 [thread overview]
Message-ID: <20181030202604.36b130ef@pinnacle.lan> (raw)
In-Reply-To: <af6bbbf0-15b2-fd5c-fcd4-a81ebd962c00@redhat.com>
On Tue, 30 Oct 2018 17:34:00 -0700
Keith Seitz <keiths@redhat.com> wrote:
> > The new patch moves the conversion from integer type to void type into
> > a new function which is now called from a couple of places, but all
> > from within dwarf2read.c:read_base_type, this catches the return type
> > and the variable type issues. The test has been renamed to remove the
> > focus on return type. Otherwise, everything is pretty similar.
> >
> > Let me know what you think.
>
> That answers all the questions I had. Thank you very much.
>
> Kevin has already approved the patch, so unless he has anything further,
> I would say this patch is good to go in.
I read through the new patch. It looks good to me also.
Kevin
next prev parent reply other threads:[~2018-10-31 3:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 21:28 Andrew Burgess
2018-10-24 17:10 ` Kevin Buettner
2018-10-24 21:00 ` Keith Seitz
2018-10-31 0:23 ` Andrew Burgess
2018-10-31 0:34 ` Keith Seitz
2018-10-31 3:26 ` Kevin Buettner [this message]
2018-11-06 18:11 ` Tom Tromey
2018-11-06 20:43 ` Andrew Burgess
2018-11-06 22:42 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181030202604.36b130ef@pinnacle.lan \
--to=kevinb@redhat.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox