From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67480 invoked by alias); 31 Oct 2018 03:26:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 67470 invoked by uid 89); 31 Oct 2018 03:26:07 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=H*M:lan X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 31 Oct 2018 03:26:06 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6AE6B30820EE; Wed, 31 Oct 2018 03:26:05 +0000 (UTC) Received: from pinnacle.lan (ovpn-116-78.phx2.redhat.com [10.3.116.78]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 323AA601A8; Wed, 31 Oct 2018 03:26:05 +0000 (UTC) Date: Wed, 31 Oct 2018 03:26:00 -0000 From: Kevin Buettner To: Andrew Burgess Cc: Keith Seitz , gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: Handle ICC's unexpected void return type Message-ID: <20181030202604.36b130ef@pinnacle.lan> In-Reply-To: References: <20181023212843.4774-1-andrew.burgess@embecosm.com> <0794714d-b2f8-6175-cc98-6000d77ea933@redhat.com> <20181031002259.GM15098@embecosm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00737.txt.bz2 On Tue, 30 Oct 2018 17:34:00 -0700 Keith Seitz wrote: > > The new patch moves the conversion from integer type to void type into > > a new function which is now called from a couple of places, but all > > from within dwarf2read.c:read_base_type, this catches the return type > > and the variable type issues. The test has been renamed to remove the > > focus on return type. Otherwise, everything is pretty similar. > > > > Let me know what you think. > > That answers all the questions I had. Thank you very much. > > Kevin has already approved the patch, so unless he has anything further, > I would say this patch is good to go in. I read through the new patch. It looks good to me also. Kevin