From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120471 invoked by alias); 24 Oct 2018 17:10:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 120449 invoked by uid 89); 24 Oct 2018 17:10:47 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:831 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 24 Oct 2018 17:10:46 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BD89F301A3BE; Wed, 24 Oct 2018 17:10:45 +0000 (UTC) Received: from pinnacle.lan (ovpn-116-78.phx2.redhat.com [10.3.116.78]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9759E5B69B; Wed, 24 Oct 2018 17:10:45 +0000 (UTC) Date: Wed, 24 Oct 2018 17:10:00 -0000 From: Kevin Buettner To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: Re: [PATCH] gdb: Handle ICC's unexpected void return type Message-ID: <20181024101044.2ca491db@pinnacle.lan> In-Reply-To: <20181023212843.4774-1-andrew.burgess@embecosm.com> References: <20181023212843.4774-1-andrew.burgess@embecosm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00553.txt.bz2 Hi Andrew, Mostly okay, just a two nits... On Tue, 23 Oct 2018 22:28:43 +0100 Andrew Burgess wrote: > diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c > index 2a1b805c9a7..7d9026a59d7 100644 > --- a/gdb/dwarf2read.c > +++ b/gdb/dwarf2read.c > @@ -551,6 +551,7 @@ struct dwarf2_cu > unsigned int checked_producer : 1; > unsigned int producer_is_gxx_lt_4_6 : 1; > unsigned int producer_is_gcc_lt_4_3 : 1; > + unsigned int producer_is_icc : 1; Use bool here like the recently added producer_is_codewarrior. And... > @@ -25134,6 +25155,7 @@ dwarf2_cu::dwarf2_cu (struct dwarf2_per_cu_data *per_cu_) > checked_producer (0), > producer_is_gxx_lt_4_6 (0), > producer_is_gcc_lt_4_3 (0), > + producer_is_icc (0), Use false instead of 0. Kevin