From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128337 invoked by alias); 6 Nov 2018 18:11:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 128272 invoked by uid 89); 6 Nov 2018 18:11:01 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway24.websitewelcome.com Received: from gateway24.websitewelcome.com (HELO gateway24.websitewelcome.com) (192.185.51.253) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 06 Nov 2018 18:11:00 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway24.websitewelcome.com (Postfix) with ESMTP id F278474E6A for ; Tue, 6 Nov 2018 12:10:58 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id K5oYgX4uDaSeyK5oYgnitZ; Tue, 06 Nov 2018 12:10:58 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=iOy9TMxQ03gCgObaIhvkMq3AHCv/XpjAi4Ra+wHj78w=; b=XN+G8RXYhYb7EHtL7f1WJl/FhP j/OW62sJ9DsIz8lB8FD54MLHGsuCmrkqs9720xvq4I24enP4Co8vS2nEuWHNVzrKtorCCKzZv7KXE e0t+NNDoadeHhn2pbFeXdfBbG; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:39624 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gK5oY-000M1y-Lj; Tue, 06 Nov 2018 12:10:58 -0600 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: Handle ICC's unexpected void return type References: <20181023212843.4774-1-andrew.burgess@embecosm.com> Date: Tue, 06 Nov 2018 18:11:00 -0000 In-Reply-To: <20181023212843.4774-1-andrew.burgess@embecosm.com> (Andrew Burgess's message of "Tue, 23 Oct 2018 22:28:43 +0100") Message-ID: <878t26rs9a.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-11/txt/msg00069.txt.bz2 >>>>> "Andrew" == Andrew Burgess writes: Andrew> I encountered a binary compiled with Intel's C Compiler version Andrew> 14.0.5.212, which seemed to contain some non-standard DWARF. [...] Andrew> A test confirms that the issue is fixed. Thanks for this test. It's very good to have these; in the past I think some compiler workarounds have gone in without such tests, and then later it is difficult to figure out whether changes keep gdb working. Andrew> + if (bits == 0 && producer_is_icc (cu) Andrew> + && strcmp (name, "void") == 0) I think NAME can be null here, so an additional check is needed to avoid a potential crash. Tom