Re: [PATCH] debuginfod-support.c: Use long-lived debuginfod_client

[Tom Tromey <tom@tromey.com>]

>>>>> "Aaron" == Aaron Merey via Gdb-patches <gdb-patches@sourceware.org> writes:

Aaron> Instead of initializing a new debuginfod_client for each query, store
Aaron> the first initialized client for the remainder of the GDB session and
Aaron> use it for every debuginfod query.

Will this still work with existing versions of the library?

Aaron> +static debuginfod_client *global_client = nullptr;

Will there ever be a need to finalize this object?  Like, shut it down
cleanly in some way?

Aaron> -static debuginfod_client_up
Aaron> +static debuginfod_client *
Aaron>  debuginfod_init ()
Aaron>  {
Aaron> -  debuginfod_client_up c (debuginfod_begin ());
Aaron> +  if (global_client == nullptr)

If global_client were defined here, rather than globally, then that
would help enforce the rule that the only way to get a
debuginfod_client* is to call debuginfod_init.

Other than this nit, the patch looks good to me.

thanks,
Tom