From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
To: Aaron Merey <amerey@redhat.com>
Cc: fche@redhat.com, tom@tromey.com, gdb-patches@sourceware.org
Subject: Re: [PATCH] debuginfod-support.c: Use long-lived debuginfod_client
Date: Thu, 6 May 2021 17:45:19 -0400 [thread overview]
Message-ID: <5de1248e-52c9-2e11-db33-1e039a1986b2@polymtl.ca> (raw)
In-Reply-To: <20210506203513.525551-1-amerey@redhat.com>
> Instead of initializing a new debuginfod_client for each query, store
> the first initialized client for the remainder of the GDB session and
> use it for every debuginfod query.
>
> In conjunction with upcoming changes to libdebuginfod, using one client
> for all queries will avoid latency caused by unneccesarily setting up
> TCP connections multiple times.
>
> Tested on Fedora 33 x86_64.
>
> gdb/ChangeLog:
>
> * debuginfod-support.c (debuginfod_init): Remove.
> (get_debuginfod_client): New function.
LGTM, thanks!
Simon
prev parent reply other threads:[~2021-05-06 21:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 23:57 Aaron Merey via Gdb-patches
2021-05-04 14:27 ` Tom Tromey
2021-05-06 0:55 ` Frank Ch. Eigler via Gdb-patches
2021-05-06 17:27 ` Aaron Merey via Gdb-patches
2021-05-06 17:39 ` Tom Tromey
2021-05-06 18:03 ` Simon Marchi via Gdb-patches
2021-05-06 18:47 ` Frank Ch. Eigler via Gdb-patches
2021-05-06 19:11 ` Simon Marchi via Gdb-patches
2021-05-06 20:35 ` Aaron Merey via Gdb-patches
2021-05-06 21:45 ` Simon Marchi via Gdb-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5de1248e-52c9-2e11-db33-1e039a1986b2@polymtl.ca \
--to=gdb-patches@sourceware.org \
--cc=amerey@redhat.com \
--cc=fche@redhat.com \
--cc=simon.marchi@polymtl.ca \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox