From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id rdcjGHtjlGBwLwAAWB0awg (envelope-from ) for ; Thu, 06 May 2021 17:45:31 -0400 Received: by simark.ca (Postfix, from userid 112) id 55A4E1F11C; Thu, 6 May 2021 17:45:31 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B26251E783 for ; Thu, 6 May 2021 17:45:30 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3614D3AAB02F; Thu, 6 May 2021 21:45:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3614D3AAB02F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1620337530; bh=+Kh9tGaezZOkXpstqDFQznZ1HgIAUkyN4//K/D8hI2I=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=PysbUaBJoOe/9i93H0gDmcAUzyHROukNviSwN8AqVhEz7pujDUaGhhXF7U21bOtDz Uk1XIurabAbMCU8MDjnGjVOvjLbHtUYmaWysBF6jT31mp02qsbYb4KkieGFMTLcM/Z G1jgpRX2VtepUY4uz08g/a/jw/ew1Ru+vFtP/zKs= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 2F6963AAB027 for ; Thu, 6 May 2021 21:45:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2F6963AAB027 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 146LjK5R032317 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 6 May 2021 17:45:24 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 146LjK5R032317 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id D65D71E783; Thu, 6 May 2021 17:45:19 -0400 (EDT) Subject: Re: [PATCH] debuginfod-support.c: Use long-lived debuginfod_client To: Aaron Merey References: <20210506203513.525551-1-amerey@redhat.com> Message-ID: <5de1248e-52c9-2e11-db33-1e039a1986b2@polymtl.ca> Date: Thu, 6 May 2021 17:45:19 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210506203513.525551-1-amerey@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 6 May 2021 21:45:20 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Cc: fche@redhat.com, tom@tromey.com, gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" > Instead of initializing a new debuginfod_client for each query, store > the first initialized client for the remainder of the GDB session and > use it for every debuginfod query. > > In conjunction with upcoming changes to libdebuginfod, using one client > for all queries will avoid latency caused by unneccesarily setting up > TCP connections multiple times. > > Tested on Fedora 33 x86_64. > > gdb/ChangeLog: > > * debuginfod-support.c (debuginfod_init): Remove. > (get_debuginfod_client): New function. LGTM, thanks! Simon