Re: [PATCH] debuginfod-support.c: Use long-lived debuginfod_client

["Frank Ch. Eigler via Gdb-patches" <gdb-patches@sourceware.org>]

Hi -

> I think it would still be a good idea to properly close the client
> at exit.  Not because the memory leak is a concern, but because we
> shouldn't assume what closing a debuginfod client (current or
> future) does or does not do, so we shouldn't assume that we can get
> away without calling debuginfo_end.

If it's not hard to do, sure .... but wouldn't that necessitate
exposing the pointer from function static scope again?


> A debuginfod client could eventually maintain some temporary files
> that need to be deleted when closing in order not to litter /tmp,
> some cache files need to be flushed, etc.

I suspect that if we were to do any of those things in the future,
we'd keep things clean by techniques like holding onto fd's to
unlinked files, so process exit is enough.  (We could make a
commitment in the docs.)


- FChE