From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ld7LDfVZkWCyYwAAWB0awg (envelope-from ) for ; Tue, 04 May 2021 10:28:05 -0400 Received: by simark.ca (Postfix, from userid 112) id 2B9E61F11C; Tue, 4 May 2021 10:28:05 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,RDNS_DYNAMIC,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 40DB71E54D for ; Tue, 4 May 2021 10:28:04 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E44FD395C41A; Tue, 4 May 2021 14:28:03 +0000 (GMT) Received: from gateway30.websitewelcome.com (gateway30.websitewelcome.com [192.185.149.4]) by sourceware.org (Postfix) with ESMTPS id 5718C395C41A for ; Tue, 4 May 2021 14:28:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5718C395C41A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway30.websitewelcome.com (Postfix) with ESMTP id A96FF34F86 for ; Tue, 4 May 2021 09:27:56 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id dw1jlSkJUPkftdw1klWRmV; Tue, 04 May 2021 09:27:56 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=4mxulqhvi24bWz59HGgo4lU/UZNlzYh1oEmf1CVJv5M=; b=M7bEtcUW8I2Mam7x4aKSLfEWqs CXda2IUJ3pmFGMkwxxUV6DNuvZlZlm+GE+kALIF1fGZ+lNtJtLb7pxGWXUDvxa0JnMRUsJ1fwHsqR SVIsgx9U9ZcTb1eycRNuug8dx; Received: from 97-122-70-176.hlrn.qwest.net ([97.122.70.176]:55142 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1ldw1j-000P4L-MP; Tue, 04 May 2021 08:27:55 -0600 From: Tom Tromey To: Aaron Merey via Gdb-patches Subject: Re: [PATCH] debuginfod-support.c: Use long-lived debuginfod_client References: <20210430235735.1371915-1-amerey@redhat.com> X-Attribution: Tom Date: Tue, 04 May 2021 08:27:55 -0600 In-Reply-To: <20210430235735.1371915-1-amerey@redhat.com> (Aaron Merey via Gdb-patches's message of "Fri, 30 Apr 2021 19:57:35 -0400") Message-ID: <878s4utvys.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.70.176 X-Source-L: No X-Exim-ID: 1ldw1j-000P4L-MP X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-70-176.hlrn.qwest.net (murgatroyd) [97.122.70.176]:55142 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Aaron" == Aaron Merey via Gdb-patches writes: Aaron> Instead of initializing a new debuginfod_client for each query, store Aaron> the first initialized client for the remainder of the GDB session and Aaron> use it for every debuginfod query. Will this still work with existing versions of the library? Aaron> +static debuginfod_client *global_client = nullptr; Will there ever be a need to finalize this object? Like, shut it down cleanly in some way? Aaron> -static debuginfod_client_up Aaron> +static debuginfod_client * Aaron> debuginfod_init () Aaron> { Aaron> - debuginfod_client_up c (debuginfod_begin ()); Aaron> + if (global_client == nullptr) If global_client were defined here, rather than globally, then that would help enforce the rule that the only way to get a debuginfod_client* is to call debuginfod_init. Other than this nit, the patch looks good to me. thanks, Tom