From: Tom Tromey <tromey@redhat.com>
To: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH v3 10/13] don't check for unistd.h
Date: Wed, 20 Nov 2013 15:54:00 -0000 [thread overview]
Message-ID: <877gc3jcoy.fsf@fleche.redhat.com> (raw)
In-Reply-To: <8738mskqam.fsf@fleche.redhat.com> (Tom Tromey's message of "Tue, 19 Nov 2013 14:57:53 -0700")
Tom> I'm probably going to revert the whole series tomorrow morning.
Tom> I'll send a bug report to gnulib.
Ok, I dug some more, and I discovered that the gnulib "strerror" module
is the root of our trouble. Dropping it fixes the problem.
Therefore I'm checking in the appended patch. (I omitted all the
auto-generated crud from it for clarity.)
I send a second note to bug-gnulib with my findings.
I am somewhat more skeptical of gnulib after this experience.
Tom
From 079a28f2235d6c294f643351d2bee248e311b025 Mon Sep 17 00:00:00 2001
From: Tom Tromey <tromey@redhat.com>
Date: Wed, 20 Nov 2013 08:19:05 -0700
Subject: [PATCH] remove strerror module
This fixes the mingw build breakage reported by Pierre.
I found that the gnulib strerror module somehow requires us to pull in
the gethostname module. However, pulling in the gethostname module
makes many things break.
I've sent a bug report to gnulib.
Meanwhile, removing the strerror module should not harm gdb and fixes
the build.
I'm checking this in.
2013-11-20 Tom Tromey <tromey@redhat.com>
* gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Remove
strerror module.
* gnulib/aclocal.m4: Update.
* gnulib/config.in: Update.
* gnulib/configure: Update.
* gnulib/import/Makefile.am: Update.
* gnulib/import/Makefile.in: Update.
* gnulib/import/errno.in.h: Remove.
* gnulib/import/intprops.h: Remove.
* gnulib/import/m4/errno_h.m4: Remove.
* gnulib/import/m4/gnulib-cache.m4: Update.
* gnulib/import/m4/gnulib-comp.m4: Update.
* gnulib/import/m4/strerror.m4: Remove.
* gnulib/import/m4/sys_socket_h.m4: Remove.
* gnulib/import/strerror-override.c: Remove.
* gnulib/import/strerror-override.h: Remove.
* gnulib/import/strerror.c: Remove.
* gnulib/update-gnulib.sh: Update.
---
gdb/ChangeLog | 21 ++
gdb/gnulib/aclocal.m4 | 3 -
gdb/gnulib/config.in | 16 -
gdb/gnulib/configure | 665 ++--------------------------------
gdb/gnulib/import/Makefile.am | 61 +---
gdb/gnulib/import/Makefile.in | 84 ++---
gdb/gnulib/import/errno.in.h | 279 --------------
gdb/gnulib/import/intprops.h | 319 ----------------
gdb/gnulib/import/m4/errno_h.m4 | 137 -------
gdb/gnulib/import/m4/gnulib-cache.m4 | 3 +-
gdb/gnulib/import/m4/gnulib-comp.m4 | 25 --
gdb/gnulib/import/m4/strerror.m4 | 96 -----
gdb/gnulib/import/m4/sys_socket_h.m4 | 176 ---------
gdb/gnulib/import/strerror-override.c | 302 ---------------
gdb/gnulib/import/strerror-override.h | 56 ---
gdb/gnulib/import/strerror.c | 70 ----
gdb/gnulib/update-gnulib.sh | 1 -
17 files changed, 84 insertions(+), 2230 deletions(-)
delete mode 100644 gdb/gnulib/import/errno.in.h
delete mode 100644 gdb/gnulib/import/intprops.h
delete mode 100644 gdb/gnulib/import/m4/errno_h.m4
delete mode 100644 gdb/gnulib/import/m4/strerror.m4
delete mode 100644 gdb/gnulib/import/m4/sys_socket_h.m4
delete mode 100644 gdb/gnulib/import/strerror-override.c
delete mode 100644 gdb/gnulib/import/strerror-override.h
delete mode 100644 gdb/gnulib/import/strerror.c
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 3afa68e..4488a9f 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,24 @@
+2013-11-20 Tom Tromey <tromey@redhat.com>
+
+ * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Remove
+ strerror module.
+ * gnulib/aclocal.m4: Update.
+ * gnulib/config.in: Update.
+ * gnulib/configure: Update.
+ * gnulib/import/Makefile.am: Update.
+ * gnulib/import/Makefile.in: Update.
+ * gnulib/import/errno.in.h: Remove.
+ * gnulib/import/intprops.h: Remove.
+ * gnulib/import/m4/errno_h.m4: Remove.
+ * gnulib/import/m4/gnulib-cache.m4: Update.
+ * gnulib/import/m4/gnulib-comp.m4: Update.
+ * gnulib/import/m4/strerror.m4: Remove.
+ * gnulib/import/m4/sys_socket_h.m4: Remove.
+ * gnulib/import/strerror-override.c: Remove.
+ * gnulib/import/strerror-override.h: Remove.
+ * gnulib/import/strerror.c: Remove.
+ * gnulib/update-gnulib.sh: Update.
+
2013-11-19 Yao Qi <yao@codesourcery.com>
* lib/mi-support.exp (mi_child_regexp): Remove 'whatever'.
diff --git a/gdb/gnulib/update-gnulib.sh b/gdb/gnulib/update-gnulib.sh
index 5bbe65e..21f0b59 100644
--- a/gdb/gnulib/update-gnulib.sh
+++ b/gdb/gnulib/update-gnulib.sh
@@ -37,7 +37,6 @@ IMPORTED_GNULIB_MODULES="\
update-copyright \
unistd \
pathmax \
- strerror \
strstr \
dirent \
sys_stat \
--
1.8.1.4
next prev parent reply other threads:[~2013-11-20 15:50 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-18 20:27 [PATCH v3 00/13] use gnulib more heavily Tom Tromey
2013-11-18 20:26 ` [PATCH v3 02/13] change how list of modules is computed Tom Tromey
2013-11-18 20:26 ` [PATCH v3 01/13] link gdbreplay against gnulib Tom Tromey
2013-11-18 20:27 ` [PATCH v3 03/13] import strstr and strerror modules Tom Tromey
2013-11-18 20:27 ` [PATCH v3 07/13] remove gdb_dirent.h Tom Tromey
2013-11-18 20:37 ` [PATCH v3 11/13] sys/types.h cleanup Tom Tromey
2013-11-18 20:37 ` [PATCH v3 12/13] import gnulib sys/stat.h module Tom Tromey
2013-11-18 20:39 ` [PATCH v3 08/13] don't check for stddef.h Tom Tromey
2013-11-18 20:46 ` [PATCH v3 04/13] remove gdb_string.h Tom Tromey
2013-11-18 20:46 ` [PATCH v3 10/13] don't check for unistd.h Tom Tromey
2013-11-19 20:59 ` Pierre Muller
[not found] ` <"00ee01cee569$bcb52d00$361f8700$@muller"@ics-cnrs.unistra.fr>
2013-11-19 21:27 ` Eli Zaretskii
[not found] ` <13494.0459196971$1384894582@news.gmane.org>
2013-11-19 21:58 ` Tom Tromey
2013-11-19 23:43 ` Tom Tromey
2013-11-20 2:42 ` Joel Brobecker
2013-11-20 3:47 ` Eli Zaretskii
2013-11-20 12:16 ` Pierre Muller
2013-11-20 15:54 ` Tom Tromey [this message]
2013-11-20 18:03 ` Eli Zaretskii
2013-11-20 18:57 ` Joel Brobecker
2013-11-18 20:46 ` [PATCH v3 09/13] stdlib.h is universal too Tom Tromey
2013-11-18 21:12 ` [PATCH v3 06/13] import gnulib dirent module Tom Tromey
2013-11-18 21:28 ` [PATCH v3 05/13] don't check for string.h or strings.h Tom Tromey
2013-11-18 23:03 ` [PATCH v3 13/13] remove gdb_stat.h Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877gc3jcoy.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox