From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31420 invoked by alias); 20 Nov 2013 15:50:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31350 invoked by uid 89); 20 Nov 2013 15:50:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 20 Nov 2013 15:49:30 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAKFnJvb017742 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 20 Nov 2013 10:49:20 -0500 Received: from barimba (ovpn-113-124.phx2.redhat.com [10.3.113.124]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rAKFnHmX027418 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 20 Nov 2013 10:49:18 -0500 From: Tom Tromey To: "Pierre Muller" Cc: Subject: Re: [PATCH v3 10/13] don't check for unistd.h References: <1384806318-12231-1-git-send-email-tromey@redhat.com> <1384806318-12231-11-git-send-email-tromey@redhat.com> <13494.0459196971$1384894582@news.gmane.org> <877gc4ksnz.fsf@fleche.redhat.com> <8738mskqam.fsf@fleche.redhat.com> Date: Wed, 20 Nov 2013 15:54:00 -0000 In-Reply-To: <8738mskqam.fsf@fleche.redhat.com> (Tom Tromey's message of "Tue, 19 Nov 2013 14:57:53 -0700") Message-ID: <877gc3jcoy.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-11/txt/msg00598.txt.bz2 Tom> I'm probably going to revert the whole series tomorrow morning. Tom> I'll send a bug report to gnulib. Ok, I dug some more, and I discovered that the gnulib "strerror" module is the root of our trouble. Dropping it fixes the problem. Therefore I'm checking in the appended patch. (I omitted all the auto-generated crud from it for clarity.) I send a second note to bug-gnulib with my findings. I am somewhat more skeptical of gnulib after this experience. Tom >From 079a28f2235d6c294f643351d2bee248e311b025 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Wed, 20 Nov 2013 08:19:05 -0700 Subject: [PATCH] remove strerror module This fixes the mingw build breakage reported by Pierre. I found that the gnulib strerror module somehow requires us to pull in the gethostname module. However, pulling in the gethostname module makes many things break. I've sent a bug report to gnulib. Meanwhile, removing the strerror module should not harm gdb and fixes the build. I'm checking this in. 2013-11-20 Tom Tromey * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Remove strerror module. * gnulib/aclocal.m4: Update. * gnulib/config.in: Update. * gnulib/configure: Update. * gnulib/import/Makefile.am: Update. * gnulib/import/Makefile.in: Update. * gnulib/import/errno.in.h: Remove. * gnulib/import/intprops.h: Remove. * gnulib/import/m4/errno_h.m4: Remove. * gnulib/import/m4/gnulib-cache.m4: Update. * gnulib/import/m4/gnulib-comp.m4: Update. * gnulib/import/m4/strerror.m4: Remove. * gnulib/import/m4/sys_socket_h.m4: Remove. * gnulib/import/strerror-override.c: Remove. * gnulib/import/strerror-override.h: Remove. * gnulib/import/strerror.c: Remove. * gnulib/update-gnulib.sh: Update. --- gdb/ChangeLog | 21 ++ gdb/gnulib/aclocal.m4 | 3 - gdb/gnulib/config.in | 16 - gdb/gnulib/configure | 665 ++-------------------------------- gdb/gnulib/import/Makefile.am | 61 +--- gdb/gnulib/import/Makefile.in | 84 ++--- gdb/gnulib/import/errno.in.h | 279 -------------- gdb/gnulib/import/intprops.h | 319 ---------------- gdb/gnulib/import/m4/errno_h.m4 | 137 ------- gdb/gnulib/import/m4/gnulib-cache.m4 | 3 +- gdb/gnulib/import/m4/gnulib-comp.m4 | 25 -- gdb/gnulib/import/m4/strerror.m4 | 96 ----- gdb/gnulib/import/m4/sys_socket_h.m4 | 176 --------- gdb/gnulib/import/strerror-override.c | 302 --------------- gdb/gnulib/import/strerror-override.h | 56 --- gdb/gnulib/import/strerror.c | 70 ---- gdb/gnulib/update-gnulib.sh | 1 - 17 files changed, 84 insertions(+), 2230 deletions(-) delete mode 100644 gdb/gnulib/import/errno.in.h delete mode 100644 gdb/gnulib/import/intprops.h delete mode 100644 gdb/gnulib/import/m4/errno_h.m4 delete mode 100644 gdb/gnulib/import/m4/strerror.m4 delete mode 100644 gdb/gnulib/import/m4/sys_socket_h.m4 delete mode 100644 gdb/gnulib/import/strerror-override.c delete mode 100644 gdb/gnulib/import/strerror-override.h delete mode 100644 gdb/gnulib/import/strerror.c diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 3afa68e..4488a9f 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,24 @@ +2013-11-20 Tom Tromey + + * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Remove + strerror module. + * gnulib/aclocal.m4: Update. + * gnulib/config.in: Update. + * gnulib/configure: Update. + * gnulib/import/Makefile.am: Update. + * gnulib/import/Makefile.in: Update. + * gnulib/import/errno.in.h: Remove. + * gnulib/import/intprops.h: Remove. + * gnulib/import/m4/errno_h.m4: Remove. + * gnulib/import/m4/gnulib-cache.m4: Update. + * gnulib/import/m4/gnulib-comp.m4: Update. + * gnulib/import/m4/strerror.m4: Remove. + * gnulib/import/m4/sys_socket_h.m4: Remove. + * gnulib/import/strerror-override.c: Remove. + * gnulib/import/strerror-override.h: Remove. + * gnulib/import/strerror.c: Remove. + * gnulib/update-gnulib.sh: Update. + 2013-11-19 Yao Qi * lib/mi-support.exp (mi_child_regexp): Remove 'whatever'. diff --git a/gdb/gnulib/update-gnulib.sh b/gdb/gnulib/update-gnulib.sh index 5bbe65e..21f0b59 100644 --- a/gdb/gnulib/update-gnulib.sh +++ b/gdb/gnulib/update-gnulib.sh @@ -37,7 +37,6 @@ IMPORTED_GNULIB_MODULES="\ update-copyright \ unistd \ pathmax \ - strerror \ strstr \ dirent \ sys_stat \ -- 1.8.1.4