Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@redhat.com>
Subject: [PATCH v3 08/13] don't check for stddef.h
Date: Mon, 18 Nov 2013 20:39:00 -0000	[thread overview]
Message-ID: <1384806318-12231-9-git-send-email-tromey@redhat.com> (raw)
In-Reply-To: <1384806318-12231-1-git-send-email-tromey@redhat.com>

gdb already unconditionally includes stddef.h in many places.
I think there is no reason to check for its existence.

Also, Zack Weinberg's header file survey agrees:

    http://hacks.owlfolio.org/header-survey/

This patch removes the configure check and the inclusion guards.
It also removes a redundant inclusion that I noticed in defs.h.

2013-11-18  Tom Tromey  <tromey@redhat.com>

	* config.in: Rebuild.
	* configure: Rebuild.
	* configure.ac: Don't check for stddef.h.
	* defs.h: Unconditionally include stddef.h.  Remove duplicate
	inclusion.
---
 gdb/ChangeLog    | 8 ++++++++
 gdb/config.in    | 3 ---
 gdb/configure    | 2 +-
 gdb/configure.ac | 2 +-
 gdb/defs.h       | 6 ------
 5 files changed, 10 insertions(+), 11 deletions(-)

diff --git a/gdb/config.in b/gdb/config.in
index 4e3f6de..802127f 100644
--- a/gdb/config.in
+++ b/gdb/config.in
@@ -378,9 +378,6 @@
 /* Define to 1 if the system has the type `socklen_t'. */
 #undef HAVE_SOCKLEN_T
 
-/* Define to 1 if you have the <stddef.h> header file. */
-#undef HAVE_STDDEF_H
-
 /* Define to 1 if you have the <stdint.h> header file. */
 #undef HAVE_STDINT_H
 
diff --git a/gdb/configure b/gdb/configure
index b1a4d48..1d1a486 100755
--- a/gdb/configure
+++ b/gdb/configure
@@ -8756,7 +8756,7 @@ fi
 
 # elf_hp.h is for HP/UX 64-bit shared library support.
 for ac_header in nlist.h machine/reg.h poll.h sys/poll.h proc_service.h \
-                  thread_db.h stddef.h \
+                  thread_db.h \
 		  stdlib.h sys/fault.h \
 		  sys/file.h sys/filio.h sys/ioctl.h sys/param.h \
 		  sys/resource.h sys/procfs.h sys/ptrace.h ptrace.h \
diff --git a/gdb/configure.ac b/gdb/configure.ac
index 6025e89..d6b75d6 100644
--- a/gdb/configure.ac
+++ b/gdb/configure.ac
@@ -1075,7 +1075,7 @@ fi
 AC_HEADER_STDC
 # elf_hp.h is for HP/UX 64-bit shared library support.
 AC_CHECK_HEADERS([nlist.h machine/reg.h poll.h sys/poll.h proc_service.h \
-                  thread_db.h stddef.h \
+                  thread_db.h \
 		  stdlib.h sys/fault.h \
 		  sys/file.h sys/filio.h sys/ioctl.h sys/param.h \
 		  sys/resource.h sys/procfs.h sys/ptrace.h ptrace.h \
diff --git a/gdb/defs.h b/gdb/defs.h
index b1caaad..bb93742 100644
--- a/gdb/defs.h
+++ b/gdb/defs.h
@@ -48,9 +48,7 @@
    included, so it's ok to blank out gstdint.h.  */
 #define GCC_GENERATED_STDINT_H 1
 
-#ifdef HAVE_STDDEF_H
 #include <stddef.h>
-#endif
 
 #include <unistd.h>
 
@@ -606,10 +604,6 @@ enum gdb_osabi
 
 /* From other system libraries */
 
-#ifdef HAVE_STDDEF_H
-#include <stddef.h>
-#endif
-
 #ifdef HAVE_STDLIB_H
 #include <stdlib.h>
 #endif
-- 
1.8.1.4


  parent reply	other threads:[~2013-11-18 20:37 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-18 20:27 [PATCH v3 00/13] use gnulib more heavily Tom Tromey
2013-11-18 20:26 ` [PATCH v3 01/13] link gdbreplay against gnulib Tom Tromey
2013-11-18 20:26 ` [PATCH v3 02/13] change how list of modules is computed Tom Tromey
2013-11-18 20:27 ` [PATCH v3 07/13] remove gdb_dirent.h Tom Tromey
2013-11-18 20:27 ` [PATCH v3 03/13] import strstr and strerror modules Tom Tromey
2013-11-18 20:37 ` [PATCH v3 11/13] sys/types.h cleanup Tom Tromey
2013-11-18 20:37 ` [PATCH v3 12/13] import gnulib sys/stat.h module Tom Tromey
2013-11-18 20:39 ` Tom Tromey [this message]
2013-11-18 20:46 ` [PATCH v3 10/13] don't check for unistd.h Tom Tromey
2013-11-19 20:59   ` Pierre Muller
     [not found]   ` <"00ee01cee569$bcb52d00$361f8700$@muller"@ics-cnrs.unistra.fr>
2013-11-19 21:27     ` Eli Zaretskii
     [not found]   ` <13494.0459196971$1384894582@news.gmane.org>
2013-11-19 21:58     ` Tom Tromey
2013-11-19 23:43       ` Tom Tromey
2013-11-20  2:42         ` Joel Brobecker
2013-11-20  3:47         ` Eli Zaretskii
2013-11-20 12:16           ` Pierre Muller
2013-11-20 15:54         ` Tom Tromey
2013-11-20 18:03           ` Eli Zaretskii
2013-11-20 18:57           ` Joel Brobecker
2013-11-18 20:46 ` [PATCH v3 09/13] stdlib.h is universal too Tom Tromey
2013-11-18 20:46 ` [PATCH v3 04/13] remove gdb_string.h Tom Tromey
2013-11-18 21:12 ` [PATCH v3 06/13] import gnulib dirent module Tom Tromey
2013-11-18 21:28 ` [PATCH v3 05/13] don't check for string.h or strings.h Tom Tromey
2013-11-18 23:03 ` [PATCH v3 13/13] remove gdb_stat.h Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1384806318-12231-9-git-send-email-tromey@redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox