From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tromey@redhat.com>
Cc: pierre.muller@ics-cnrs.unistra.fr, gdb-patches@sourceware.org
Subject: Re: [PATCH v3 10/13] don't check for unistd.h
Date: Wed, 20 Nov 2013 18:03:00 -0000 [thread overview]
Message-ID: <838uwjez3b.fsf@gnu.org> (raw)
In-Reply-To: <877gc3jcoy.fsf@fleche.redhat.com>
> From: Tom Tromey <tromey@redhat.com>
> Cc: <gdb-patches@sourceware.org>
> Date: Wed, 20 Nov 2013 08:49:17 -0700
>
> Ok, I dug some more, and I discovered that the gnulib "strerror" module
> is the root of our trouble. Dropping it fixes the problem.
>
> Therefore I'm checking in the appended patch. (I omitted all the
> auto-generated crud from it for clarity.)
Thanks.
Should we perhaps document these incidents somewhere, so that the
reasons for these decisions are clearly visible to whoever would like
to do this in the future?
next prev parent reply other threads:[~2013-11-20 17:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-18 20:27 [PATCH v3 00/13] use gnulib more heavily Tom Tromey
2013-11-18 20:26 ` [PATCH v3 02/13] change how list of modules is computed Tom Tromey
2013-11-18 20:26 ` [PATCH v3 01/13] link gdbreplay against gnulib Tom Tromey
2013-11-18 20:27 ` [PATCH v3 03/13] import strstr and strerror modules Tom Tromey
2013-11-18 20:27 ` [PATCH v3 07/13] remove gdb_dirent.h Tom Tromey
2013-11-18 20:37 ` [PATCH v3 11/13] sys/types.h cleanup Tom Tromey
2013-11-18 20:37 ` [PATCH v3 12/13] import gnulib sys/stat.h module Tom Tromey
2013-11-18 20:39 ` [PATCH v3 08/13] don't check for stddef.h Tom Tromey
2013-11-18 20:46 ` [PATCH v3 04/13] remove gdb_string.h Tom Tromey
2013-11-18 20:46 ` [PATCH v3 10/13] don't check for unistd.h Tom Tromey
2013-11-19 20:59 ` Pierre Muller
[not found] ` <"00ee01cee569$bcb52d00$361f8700$@muller"@ics-cnrs.unistra.fr>
2013-11-19 21:27 ` Eli Zaretskii
[not found] ` <13494.0459196971$1384894582@news.gmane.org>
2013-11-19 21:58 ` Tom Tromey
2013-11-19 23:43 ` Tom Tromey
2013-11-20 2:42 ` Joel Brobecker
2013-11-20 3:47 ` Eli Zaretskii
2013-11-20 12:16 ` Pierre Muller
2013-11-20 15:54 ` Tom Tromey
2013-11-20 18:03 ` Eli Zaretskii [this message]
2013-11-20 18:57 ` Joel Brobecker
2013-11-18 20:46 ` [PATCH v3 09/13] stdlib.h is universal too Tom Tromey
2013-11-18 21:12 ` [PATCH v3 06/13] import gnulib dirent module Tom Tromey
2013-11-18 21:28 ` [PATCH v3 05/13] don't check for string.h or strings.h Tom Tromey
2013-11-18 23:03 ` [PATCH v3 13/13] remove gdb_stat.h Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=838uwjez3b.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox