Re: Regression on old kernels (Re: [PATCH v5 00/12] GDB support for more powerpc registers on linux)

Re: Regression on old kernels (Re: [PATCH v5 00/12] GDB support for more powerpc registers on linux)

[Pedro Franco de Carvalho]

Ulrich Weigand <uweigand@de.ibm.com> writes:

> Well, it doesn't really matter.  If you want to add the include,
> that's fine with me as well.

Thanks!  I've checked these in.

--
Pedro Franco de Carvalho

Re: Regression on old kernels (Re: [PATCH v5 00/12] GDB support for more powerpc registers on linux)

[Ulrich Weigand]

Pedro Franco de Carvalho wrote:

> gdb/ChangeLog:
> YYYY-MM-DD  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
> 
> 	* ppc-linux-nat.c: Include nat/linux-ptrace.h.

This is OK.
 
> gdb/gdbserver/ChangeLog:
> YYYY-MM-DD  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
> 
> 	* linux-ppc-low.c: Include nat/linux-ptrace.h.

This is probably unnecessary; linux-ppc-low.c already includes
linux-low.h which in turn includes nat/linux-ptrace.h

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU/Linux compilers and toolchain
  Ulrich.Weigand@de.ibm.com

Re: Regression on old kernels (Re: [PATCH v5 00/12] GDB support for more powerpc registers on linux)

[Pedro Franco de Carvalho]

Ulrich Weigand <uweigand@de.ibm.com> writes:

>> gdb/gdbserver/ChangeLog:
>> YYYY-MM-DD  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
>> 
>> 	* linux-ppc-low.c: Include nat/linux-ptrace.h.
>
> This is probably unnecessary; linux-ppc-low.c already includes
> linux-low.h which in turn includes nat/linux-ptrace.h

Ah I didn't notice that.  However, the wiki says I shouldn't use
definitions by indirect inclusion, and linux-low.c itself includes both
headers.  Should I still remove this?

Thanks!

--
Pedro Franco de Carvalho

Re: [PATCH v5 00/12] GDB support for more powerpc registers on linux

[Pedro Franco de Carvalho]

Pedro Alves <palves@redhat.com> writes:

> I'm fine with merging the patchset as is.

Thanks a lot! I've checked these in now.

--
Pedro Franco de Carvalho

Regression on old kernels (Re: [PATCH v5 00/12] GDB support for more powerpc registers on linux)

[Ulrich Weigand]

Pedro Franco de Carvalho wrote:
> Pedro Alves <palves@redhat.com> writes:
> 
> > I'm fine with merging the patchset as is.
> 
> Thanks a lot! I've checked these in now.

Ah, I'm now seeing a regression on my Cell (RHEL5) build bot:

gdb/ppc-linux-nat.c: In function 'void fetch_regset(regcache*, int, int, int, const regset*)':
gdb/ppc-linux-nat.c:548:15: error: 'PTRACE_GETREGSET' was not declared in this scope

There is a fallback definition for this in nat/linux-ptrace.h,
but for some reason this is not actually used in ppc-linux-nat.c
(which uses nat/gdb_ptrace.h) instead.  This probably needs to
be fixed.

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU/Linux compilers and toolchain
  Ulrich.Weigand@de.ibm.com