From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 86145 invoked by alias); 31 Oct 2018 13:05:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 86126 invoked by uid 89); 31 Oct 2018 13:05:05 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=0.0 required=5.0 tests=AWL,BAYES_00,DATE_IN_PAST_12_24,KAM_LAZY_DOMAIN_SECURITY,KHOP_DYNAMIC,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy= X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 31 Oct 2018 13:04:59 +0000 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w9VCxKrB071978 for ; Wed, 31 Oct 2018 09:04:58 -0400 Received: from e16.ny.us.ibm.com (e16.ny.us.ibm.com [129.33.205.206]) by mx0a-001b2d01.pphosted.com with ESMTP id 2nfac4fdau-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 31 Oct 2018 09:04:58 -0400 Received: from localhost by e16.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 31 Oct 2018 09:04:57 -0400 Received: from b01cxnp22034.gho.pok.ibm.com (9.57.198.24) by e16.ny.us.ibm.com (146.89.104.203) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 31 Oct 2018 09:04:56 -0400 Received: from b01ledav006.gho.pok.ibm.com (b01ledav006.gho.pok.ibm.com [9.57.199.111]) by b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w9VD4sgu1180158 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 31 Oct 2018 13:04:54 GMT Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 23E13AC062; Wed, 31 Oct 2018 13:04:54 +0000 (GMT) Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EA5E3AC064; Wed, 31 Oct 2018 13:04:53 +0000 (GMT) Received: from pedro.localdomain (unknown [9.18.235.45]) by b01ledav006.gho.pok.ibm.com (Postfix) with ESMTP; Wed, 31 Oct 2018 13:04:53 +0000 (GMT) Received: by pedro.localdomain (Postfix, from userid 1000) id A84D13C02E8; Tue, 30 Oct 2018 10:37:44 -0300 (-03) From: Pedro Franco de Carvalho To: Ulrich Weigand Cc: gdb-patches@sourceware.org Subject: Re: Regression on old kernels (Re: [PATCH v5 00/12] GDB support for more powerpc registers on linux) In-Reply-To: <20181030094423.09085D802EF@oc3748833570.ibm.com> References: <20181030094423.09085D802EF@oc3748833570.ibm.com> Date: Wed, 31 Oct 2018 13:05:00 -0000 MIME-Version: 1.0 Content-Type: text/plain x-cbid: 18103113-0072-0000-0000-000003BF25AF X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00009959; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000268; SDB=6.01110620; UDB=6.00575488; IPR=6.00890712; MB=3.00023978; MTD=3.00000008; XFM=3.00000015; UTC=2018-10-31 13:04:57 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18103113-0073-0000-0000-000049F23232 Message-Id: <87muqv7dxz.fsf@linux.vnet.ibm.com> X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00745.txt.bz2 Ulrich Weigand writes: >> gdb/gdbserver/ChangeLog: >> YYYY-MM-DD Pedro Franco de Carvalho >> >> * linux-ppc-low.c: Include nat/linux-ptrace.h. > > This is probably unnecessary; linux-ppc-low.c already includes > linux-low.h which in turn includes nat/linux-ptrace.h Ah I didn't notice that. However, the wiki says I shouldn't use definitions by indirect inclusion, and linux-low.c itself includes both headers. Should I still remove this? Thanks! -- Pedro Franco de Carvalho