From: Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Regression on old kernels (Re: [PATCH v5 00/12] GDB support for more powerpc registers on linux)
Date: Wed, 31 Oct 2018 13:05:00 -0000 [thread overview]
Message-ID: <87muqv7dxz.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <20181030094423.09085D802EF@oc3748833570.ibm.com>
Ulrich Weigand <uweigand@de.ibm.com> writes:
>> gdb/gdbserver/ChangeLog:
>> YYYY-MM-DD Pedro Franco de Carvalho <pedromfc@linux.vnet.ibm.com>
>>
>> * linux-ppc-low.c: Include nat/linux-ptrace.h.
>
> This is probably unnecessary; linux-ppc-low.c already includes
> linux-low.h which in turn includes nat/linux-ptrace.h
Ah I didn't notice that. However, the wiki says I shouldn't use
definitions by indirect inclusion, and linux-low.c itself includes both
headers. Should I still remove this?
Thanks!
--
Pedro Franco de Carvalho
next prev parent reply other threads:[~2018-10-31 13:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181029195007.9384-1-pedromfc@linux.ibm.com>
2018-10-30 9:44 ` Ulrich Weigand
2018-10-31 13:05 ` Pedro Franco de Carvalho [this message]
[not found] <20181031131444.C98DCD802AF@oc3748833570.ibm.com>
2018-10-31 14:06 ` Pedro Franco de Carvalho
2018-10-26 15:16 [PATCH v5 00/12] GDB support for more powerpc registers on linux Pedro Franco de Carvalho
2018-10-29 14:20 ` Regression on old kernels (Re: [PATCH v5 00/12] GDB support for more powerpc registers on linux) Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87muqv7dxz.fsf@linux.vnet.ibm.com \
--to=pedromfc@linux.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox