Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tom Tromey <tom@tromey.com>
Cc: Philippe Waroquiers <philippe.waroquiers@skynet.be>,
	 gdb-patches@sourceware.org
Subject: Re: GDB ui word wrapping broken/interferes with 'set style'  ?
Date: Sun, 30 Dec 2018 23:45:00 -0000	[thread overview]
Message-ID: <877efqlgu6.fsf@tromey.com> (raw)
In-Reply-To: <87ftuelq21.fsf@tromey.com> (Tom Tromey's message of "Sun, 30 Dec	2018 13:25:58 -0700")

Tom> Seems very likely.  Thanks for the report, I will look into it.

Please try this.  I think it fixes both of the styling problems you
reported, but it's better if you check it too.  If it works for you I
will write a test case.

thanks,
Tom

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 7be4360e62..0d1fcb79f1 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2018-12-30  Tom Tromey  <tom@tromey.com>
+
+	* utils.c (flush_wrap_buffer): Only flush gdb_stdout.
+
 2018-12-30  Tom Tromey  <tom@tromey.com>
 
 	* event-top.h (command_line_handler): Update.
diff --git a/gdb/utils.c b/gdb/utils.c
index 3a6f796f2b..753eb14280 100644
--- a/gdb/utils.c
+++ b/gdb/utils.c
@@ -1589,7 +1589,7 @@ reinitialize_more_filter (void)
 static void
 flush_wrap_buffer (struct ui_file *stream)
 {
-  if (!wrap_buffer.empty ())
+  if (stream == gdb_stdout && !wrap_buffer.empty ())
     {
       fputs_unfiltered (wrap_buffer.c_str (), stream);
       wrap_buffer.clear ();


  reply	other threads:[~2018-12-30 23:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-30 14:51 Philippe Waroquiers
2018-12-30 20:26 ` Tom Tromey
2018-12-30 23:45   ` Tom Tromey [this message]
2018-12-31  8:13     ` Philippe Waroquiers
2019-01-06 23:40       ` Tom Tromey
2019-01-07 13:46         ` Philippe Waroquiers
2019-01-07 14:49           ` Tom Tromey
2019-01-07 16:56             ` Philippe Waroquiers
2019-01-12 17:03               ` Tom Tromey
2019-01-12 17:55                 ` Philippe Waroquiers
2019-01-12 21:08                   ` Philippe Waroquiers
2019-01-14  3:55                     ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877efqlgu6.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=philippe.waroquiers@skynet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox